Problem/Motivation

RTL styles of Vertical tabs in Seven theme has an unneeded right margin.

Checking the code in seven.libraries.yml it seems that Seven tries to remove the inherited Vertical tabs styles, but since it is already overridden by Stable, the intention cannot achieve its purpose.

Vertical tabs RTL of Seven theme

Steps to reproduce

  1. Install Drupal with the Standard profile.
  2. Enable Language module and add an RTL language (e.g. Hebrew).
  3. Visit [docroot]/he/admin/structure/block/manage/bartik_breadcrumbs and check the block visibility conditions.

Proposed resolution

Change the path of the removed CSS asset of core/drupal.vertical-tabs.

Remaining tasks

The usuals: patch, review, commit.

User interface changes

Better RTL styles.

API changes

Nothing.

Data model changes

Nothing.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

huzooka created an issue. See original summary.

huzooka’s picture

Assigned: huzooka » Unassigned
Status: Active » Needs review
Issue tags: +RTL
FileSize
436 bytes
Thangaraj Moorthi’s picture

FileSize
46.95 KB

@huzooka #2 applied your patch,
Its working fine in 8.8.0-dev

John Cook’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs frontend framework manager review

Thank you @huzooka and @thangaraj.moorthi.

It took me a while to figure out what was going on.

misc/vertical-tabs.css sets a margin-right on the vertical tabs. (This is currently removed by seven.info.yml.)
/core/themes/stable/css/core/vertical-tabs.css also sets the right margin.
Seven then inherits the vertical-tabs style from Stable, undoing what seven.info.yml was trying to do.

This patch changes the info.yml file so that the CSS from stable is removed as well, getting rid of the rogue margins.

This is the image from @thangaraj.moorthi inlined:

I've added 'Needs frontend framework manager review' for them to review, but I'm also setting this to RTBC.

  • lauriii committed df568de on 8.8.x
    Issue #3055760 by huzooka, thangaraj.moorthi, John Cook:  Fix RTL styles...
lauriii’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs frontend framework manager review

Committed df568de and pushed to 8.8.x. Also cherry-picked to 8.7.x. Thanks!

  • lauriii committed ad48e59 on 8.7.x
    Issue #3055760 by huzooka, thangaraj.moorthi, John Cook:  Fix RTL styles...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.