Follow-up to change in #3041435: Provide an automatic local task for the Duplicate operation.

The handler needs to be declared on the type too to have the tabs show up.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

grahl created an issue. See original summary.

grahl’s picture

Status: Active » Needs review
FileSize
1.7 KB
grahl’s picture

Issue summary: View changes
RoSk0’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests

Awesome, thanks for this.

We need tests for this.

grahl’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
1.64 KB

Turns out we already had patches for that but the test is better on "Edit" instead of "Manage Fields" where Field UI takes care of it.

Status: Needs review » Needs work

The last submitted patch, 5: 3055092-5-TEST.patch, failed testing. View results

grahl’s picture

Status: Needs work » Needs review
FileSize
3.54 KB

Tests fail as expected so here is the change with the test.

Status: Needs review » Needs work

The last submitted patch, 7: 3055092-6-add-local-task-type.patch, failed testing. View results

bluegeek9’s picture

The task links are stored in crm_core_contact.links.task.yml

bluegeek9’s picture

Status: Needs work » Needs review

All tests pass.

bluegeek9’s picture

Status: Needs review » Reviewed & tested by the community

  • grahl committed 052d338 on 8.x-3.x authored by bluegeek9
    Issue #3055092 by grahl, bluegeek9: Missing local tab actions on...
grahl’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for the follow-up bluegeek9, the local task provider doesn't quite do what it promises so I'm leaving it out for now and adding the route as proposed since that works fine.

I've amended the test to check more scenarios on the listing, the edit page of the type and the Manage fields page of the type.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.