Problem/Motivation

It is quite common for the workspaces to require additional metadata. Workspaces are content entities, so they support fields but there's no ui for managing them.

Proposed resolution

Add the field_ui tabs on /admin/config/workflow/workspaces.

User interface changes

Field UI tabs showing up on the workspace listing page.

API changes

None.

Data model changes

None.

Release notes snippet

Workspaces now have the field ui tabs on the listing page.

CommentFileSizeAuthor
#9 3054582-9.patch3 KBjeqq
#9 interdiff.txt513 bytesjeqq
#7 3054582-7.patch3.01 KBjeqq
#7 interdiff.txt1.94 KBjeqq
#2 3054582-2.patch943 bytesblazey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

blazey created an issue. See original summary.

blazey’s picture

blazey CreditAttribution: blazey at Amazee Labs commented
Assigned: blazey » Unassigned
Issue summary: View changes
Status: Active » Needs review
FileSize
3054582-2.patch943 bytes
Leksat’s picture

Leksat CreditAttribution: Leksat at Amazee Labs commented
Status: Needs review » Reviewed & tested by the community

Tested manually. Looks good!

Also, the "Manage display" tab probably makes no sense. Or it does?

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

I asked @amateescu about this, he wrote on slack:

I just saw it a bit earlier, didn't have time to comment yet :) +1 from me

blazey’s picture

blazey CreditAttribution: blazey at Amazee Labs commented

Thanks for review. I think Manage display might make sense. A list of workspaces can be displayed with views for instance.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

This makes sense, but we need some tests here to make sure this functionality doesn't regress.

Thanks

jeqq’s picture

jeqq
Primary language Romanian
CreditAttribution: jeqq for Pfizer, Inc. commented
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
interdiff.txt1.94 KB
3054582-7.patch3.01 KB

Added a test.

jeqq’s picture

jeqq
Primary language Romanian
CreditAttribution: jeqq for Pfizer, Inc. commented
Issue tags: +DevDaysTransylvania, +DevDaysCluj
jeqq’s picture

jeqq
Primary language Romanian
CreditAttribution: jeqq for Pfizer, Inc. commented
FileSize
interdiff.txt513 bytes
3054582-9.patch3 KB

Modified the method comment.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Workflow Initiative

The test looks great, thanks!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Fixed

Superb!

Committed b759a93 and pushed to 8.8.x. Thanks!

  • Gábor Hojtsy committed b759a93 on 8.8.x 
    Issue #3054582 by jeqq, blazey, Leksat, Gábor Hojtsy, larowlan,...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: +8.8.0 highlights
amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Fixed » Reviewed & tested by the community

Thanks, @Gábor! This should be backportable to 8.7.x since Workspaces is still experimental :)

Manuel Garcia’s picture

Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer commented

Patch #9 applies cleanly to 8.7.x - queued the patch to test against that just now.

rosinegrean’s picture

rosinegrean CreditAttribution: rosinegrean at PitechPlus commented
Issue tags: -DevDaysCluj
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Cherry-picked to 8.7.x, thanks!

  • catch committed b2af74b on 8.7.x authored by Gábor Hojtsy 
    Issue #3054582 by jeqq, blazey, Leksat, Gábor Hojtsy, larowlan,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Issue tags: -8.8.0 highlights

Removing a tag since this was committed to 8.7.x too.