Remove PriceListItemStorage because it is not required and causes an issue with Default Content.

Discussed with @bojanz on Slack

CommentFileSizeAuthor
#2 Issue_#3053433__Remove_PriceListItemStorage.patch1.41 KBdwkitchen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dwkitchen created an issue. See original summary.

dwkitchen’s picture

dwkitchen CreditAttribution: dwkitchen commented
Issue summary: View changes
FileSize
Issue_#3053433__Remove_PriceListItemStorage.patch1.41 KB

Patch attached

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Active » Needs review
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Title: Remove PriceListItemStorage » PriceListItemStorage::doCreate() prevents price list items from being created via REST

Better title. We had the same problem in Commerce for payments and payment methods, fixed in #2988625: Cannot create payments and payment methods via REST.

I would like to add the same validation to PriceListItem::preSave() though. That won't interfere with other modules, but it will still ensure that non-broken data is being saved.

  • bojanz committed b8c619a on 8.x-2.x authored by dwkitchen 
    Issue #3053433 by dwkitchen, bojanz: PriceListItemStorage::doCreate()...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Added the preSave() and committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.