CommentFileSizeAuthor
#7 crm_core-3053155-2-7-interdiff.txt4.34 KBRoSk0
#7 crm_core-3053155-7.patch19.13 KBRoSk0
#5 crm_core-3053155-3-5-interdiff.txt3.08 KBRoSk0
#5 crm_core-3053155-5-test-only.patch4.32 KBRoSk0
#3 crm_core-3053155-3-test-only.patch2.2 KBRoSk0
#2 3053155-2-incorrect-return-attribute.patch17.56 KBgrahl
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

grahl created an issue. See original summary.

grahl’s picture

grahl
he/him
Location Zürich
CreditAttribution: grahl at Liip commented
Assigned: Unassigned » RoSk0
Status: Active » Needs review
FileSize
3053155-2-incorrect-return-attribute.patch17.56 KB

I found an issue with the wrong attribute being returned in getIndividualUserId(). This patches fixes that and renames the functions of the service to a more predictable pattern plus some type hints since I found it quite difficult to discern what they do from the function names.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer and at Catalyst IT commented
FileSize
crm_core-3053155-3-test-only.patch2.2 KB

Hi Hendrik,

Thanks for that!

Lets fix the tests first, so we base ground.

Status: Needs review » Needs work

The last submitted patch, 3: crm_core-3053155-3-test-only.patch, failed testing. View results

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer and at Catalyst IT commented
Status: Needs work » Needs review
FileSize
crm_core-3053155-5-test-only.patch4.32 KB
crm_core-3053155-3-5-interdiff.txt3.08 KB

Good.

Also I noticed that "expected" and actual parameters are mixed up, fixed, and added random uid in other tests.

Status: Needs review » Needs work

The last submitted patch, 5: crm_core-3053155-5-test-only.patch, failed testing. View results

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer and at Catalyst IT commented
Status: Needs work » Needs review
FileSize
crm_core-3053155-7.patch19.13 KB
crm_core-3053155-2-7-interdiff.txt4.34 KB

Nice.

Full fix.

  • RoSk0 committed b0d54c5 on 8.x-3.x authored by grahl 
    Issue #3053155 by RoSk0, grahl: User sync: Incorrect return attribute...
RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer and at Catalyst IT commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.