Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We've noticed that the patch we submitted was not applied completely. This led to some changes and corrections not making it to the theme.
For reference, here are the links to the patch and the commit that merged the patch to the project repo.
- Patch: https://www.drupal.org/files/issues/2019-04-05/uswds-2.0.patch
- Commit in repo: https://git.drupalcode.org/project/uswds/commit/7b237c7
Attached is a follow-up patch containing those missing fixes.
Comment | File | Size | Author |
---|---|---|---|
#4 | uswds-additional_fixes.patch | 4.58 KB | fskreuz |
Comments
Comment #2
fskreuz CreditAttribution: fskreuz commentedComment #3
Irisibk CreditAttribution: Irisibk at CivicActions commented@fskreuz as always, thanks for all your work on this. I listed a couple of questions below.
Also, can we break this up into smaller pieces? It would be great to isolate & merge your page.html.twig fixes.
.usa-unstyled-list was replaced with .usa-list.usa-list--unstyled in v2.0.0 Beta7
Do we want to remove the site slogan? This will affect users that are currently displaying theirs.
Comment #4
fskreuz CreditAttribution: fskreuz commentedHi!
Attached is a patch of new changes. This one omits the page.html.twig entirely. It was mostly indentation anyways, and #3053835 pretty much addressed the main issue in that file. The new file also contains a bunch of little tweaks as well:
- re: slogan, the library does not provide anything for a slogan so I initially removed it. Now it's back, but styled with
usa-logo__text
so that it matches the site name styling, instead of the larger<h2>
.- re: list reset, I removed that entirely. That block preprocess applies the attributes to the block container, so it's not really the right place to put the list classes.
- Local action items are printed directly as
<li>
. Added a template for local actions which wraps them in a<ul class="usa-list usa-list--unstyled">
to apply the reset correctly and have markup that makes sense.Comment #7
Irisibk CreditAttribution: Irisibk at CivicActions commented