Problem/Motivation

On the quest to kill entity manager, berdir and I discussed this as a good choke point to kill a large number of usages in tests. We can use the deprecated service property trait to trigger an error on entityManager usage here and remove about 100 usages in tests from core.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3052272-2.drupal.Remove-entityManager-use-in-EntityKernelTestBase-and-all-tests-which-extend-it.patch51.78 KBmikelutz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikelutz created an issue. See original summary.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer and at ICON Interactive commented
Status: Active » Needs review
FileSize
3052272-2.drupal.Remove-entityManager-use-in-EntityKernelTestBase-and-all-tests-which-extend-it.patch51.78 KB

Pretty straightforward, I hope...

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/tests/Drupal/KernelTests/Core/Entity/EntityKernelTestBase.php
@@ -169,7 +169,7 @@ protected function uninstallModule($module) {
    */
   protected function refreshServices() {
     $this->container = \Drupal::getContainer();
-    $this->entityManager = $this->container->get('entity.manager');
+
     $this->entityTypeManager = $this->container->get('entity_type.manager');
     $this->state = $this->container->get('state');
   }

Thought if this a problem, but the new DeprecatedServicePropertyTrait doesn't set it, so every call will go directly to \Drupal::service(), which means there's no problem with stale objects.

This a simple search & replace that makes sense as a standalone issue.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer and at ICON Interactive commented

That was my conclusion on the refreshServices call as well.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

👊Committed b9f30c9 and pushed to 8.8.x. Thanks!

  • larowlan committed b9f30c9 on 8.8.x 
    Issue #3052272 by mikelutz: Remove entityManager use in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.