drupal-check against applenews-8.x-1.x-dev (28 Mar 2019).

 ------ ------------------------------------------------------------------------- 
  Line   src/Controller/ApplenewsChannelController.php                            
 ------ ------------------------------------------------------------------------- 
  62     Call to deprecated method urlInfo() of class Drupal\Core\Entity\Entity.  
 ------ ------------------------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/ApplenewsTemplateForm.php                 
 ------ --------------------------------------------------- 
  394    Call to deprecated function drupal_set_message().  
  466    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ---------------------------------------------- 
  Line   src/Form/TextStyleForm.php                    
 ------ ---------------------------------------------- 
  277    Call to deprecated method urlInfo() of class  
         Drupal\Core\Config\Entity\ConfigEntityBase.   
 ------ ---------------------------------------------- 

                                                                                
 [ERROR] Found 4 errors
CommentFileSizeAuthor
#12 Screenshot from 2021-01-22 23-03-57.png165.58 KBankithashetty
#12 interdiff_3052003_11-12.txt1.72 KBankithashetty
#12 3052003-12.patch10.92 KBankithashetty
#11 interdiff_3052003_9-11.txt6.23 KBankithashetty
#11 3052003-11.patch9.36 KBankithashetty
#9 interdiff.3052003.8-9.txt2.28 KBbrianfisher
#9 3052003-9.applenews.Drupal-9-Deprecated-Code-Report.patch4.11 KBbrianfisher
#8 Screenshot 2019-06-08 at 19.15.00.png61 KBvijaycs85
#8 3052003-8.patch4.19 KBvijaycs85
#6 applenews-3052003-6.patch2.25 KByoftahe.addweb
#4 applenews-3052003-3.patch1.18 KByoftahe.addweb

Issue fork applenews-3052003

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

waverate created an issue. See original summary.

waverate’s picture

waverate CreditAttribution: waverate commented
Related issues: +#3030480: Replace deprecated drupal_set_message function for ApplenewsTemplateForm

Patch at #2 #3030480: Replace deprecated drupal_set_message function for ApplenewsTemplateForm fixes drupal_set_message() errors but still leaves:

 ------ ------------------------------------------------------------------------- 
  Line   src/Controller/ApplenewsChannelController.php                            
 ------ ------------------------------------------------------------------------- 
  62     Call to deprecated method urlInfo() of class Drupal\Core\Entity\Entity.  
 ------ ------------------------------------------------------------------------- 

 ------ ---------------------------------------------- 
  Line   src/Form/TextStyleForm.php                    
 ------ ---------------------------------------------- 
  277    Call to deprecated method urlInfo() of class  
         Drupal\Core\Config\Entity\ConfigEntityBase.   
 ------ ---------------------------------------------- 

                                                                                
 [ERROR] Found 2 errors
yoftahe.addweb’s picture

yoftahe.addweb CreditAttribution: yoftahe.addweb at AddWeb Solution Pvt. Ltd. commented

@waverate, Please find updated for the same as per your above-mentioned comments, hope this will helps

Thanks

yoftahe.addweb’s picture

yoftahe.addweb CreditAttribution: yoftahe.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Active » Needs review
FileSize
applenews-3052003-3.patch1.18 KB
waverate’s picture

waverate CreditAttribution: waverate commented
Status: Needs review » Needs work

Patch at #4 applied to applenews-8.x-1.x-dev (28 Mar 2019), with #2 of #3030480: Replace deprecated drupal_set_message function for ApplenewsTemplateForm applied first, still leaves drupal-check with the following error:

 ------ ---------------------------------------------------------------- 
  Line   src/ApplenewsPreviewBuilder.php                                 
 ------ ---------------------------------------------------------------- 
  160    Call to deprecated function file_prepare_directory().           
  177    Call to deprecated function file_unmanaged_delete_recursive().  
  191    Call to deprecated function file_unmanaged_delete_recursive().  
  300    Call to deprecated function file_unmanaged_save_data().         
  309    Call to deprecated function file_unmanaged_save_data().         
  352    Call to deprecated function file_unmanaged_delete().            
 ------ ---------------------------------------------------------------- 

                                                                                
 [ERROR] Found 6 errors
yoftahe.addweb’s picture

yoftahe.addweb CreditAttribution: yoftahe.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
applenews-3052003-6.patch2.25 KB

@waverate, kindly review the new patch with the changes mentioned above. Hope now it resolves all.

Thanks

waverate’s picture

waverate CreditAttribution: waverate commented

@nilesh.addweb. That's good. Can you please roll patches at #3 and #6 together in a single patch?

Also, in your post mention it needs to be applied after patch #2 from #3030480: Replace deprecated drupal_set_message function for ApplenewsTemplateForm.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Status: Needs work » Needs review
FileSize
3052003-8.patch4.19 KB
Screenshot 2019-06-08 at 19.15.00.png61 KB

Combined #4 and #6 and added changes from #3030480: Replace deprecated drupal_set_message function for ApplenewsTemplateForm. All green locally:

brianfisher’s picture

brianfisher CreditAttribution: brianfisher at Chapter Three commented
FileSize
3052003-9.applenews.Drupal-9-Deprecated-Code-Report.patch4.11 KB
interdiff.3052003.8-9.txt2.28 KB

No need to use Drupal::service to get Filesystem, it's already referenced in __construct

ankithashetty’s picture

ankithashetty
Location Karnataka, India
CreditAttribution: ankithashetty as a volunteer and at Specbee commented

Any progress on porting this module to Drupal 9? Would love to have one!

ankithashetty’s picture

ankithashetty
Location Karnataka, India
CreditAttribution: ankithashetty as a volunteer and at Specbee commented
FileSize
3052003-11.patch9.36 KB
interdiff_3052003_9-11.txt6.23 KB

Updated all the deprecated code in the module to make it ready for Drupal 8. Kindly review the patch.

Thank you!

ankithashetty’s picture

ankithashetty
Location Karnataka, India
CreditAttribution: ankithashetty as a volunteer and at Specbee commented
Issue summary: View changes
FileSize
3052003-12.patch10.92 KB
interdiff_3052003_11-12.txt1.72 KB
Screenshot from 2021-01-22 23-03-57.png165.58 KB

After applying the patch, the module could be enabled on the Drupal 9 site.

On creating a new apple news template and saving it, the following error is shown.

Updating the patch accordingly... Kindly review.

Thanks!

m4olivei made their first commit to this issue’s fork.

m4olivei opened merge request !2

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
CreditAttribution: m4olivei at Lullabot commented
Assigned: Unassigned » m4olivei

Thanks for the all the work here! I'm reviewing today, should be able to commit to the 1.x-dev branch. I opened a merge request with the patch in #12 to make review a bit easier.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
CreditAttribution: m4olivei at Lullabot commented
Status: Needs review » Reviewed & tested by the community

Patch looks great on clean Drupal 9.x, also on Drupal 8.x. Lets commit this.

  • m4olivei committed fb779c6 on 8.x-1.x 
    Issue #3052003 by ankithashetty, m4olivei, dev20.addweb, vijaycs85,...
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
CreditAttribution: m4olivei at Lullabot commented
Status: Reviewed & tested by the community » Fixed

Merges to 8.x-1.x! Thanks all.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
CreditAttribution: m4olivei at Lullabot commented
Assigned: m4olivei » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.