Problem/Motivation

At https://api.drupal.org/api/drupal/core%21includes%21entity.inc/function/... the delete() links to:
https://php.net/delete but it should link to https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...

Proposed resolution

Update the comment in core/includes/entity.inc to reference the specific function \Drupal\Core\Entity\EntityStorageInterface::delete() so that the link is correct.

Remaining tasks

  1. Write a patch
  2. Review
CommentFileSizeAuthor
#6 3051932-6.patch713 bytespameeela
#5 3051932-5.patch706 bytespameeela
#3 3051932-3.patch706 bytespameeela
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aurelianzaha created an issue. See original summary.

Version: 8.2.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Branches prior to 8.8.x are not supported, and Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

pameeela’s picture

pameeela CreditAttribution: pameeela commented
Title: wrong link behind: delete() » Update docs link to EntityStorageInterface::delete() in core/includes/entity.inc
Issue summary: View changes
Status: Active » Needs review
Issue tags: +Bug Smash Initiative
FileSize
3051932-3.patch706 bytes

Patch attached.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented 
+++ b/core/includes/entity.inc
@@ -233,7 +233,7 @@ function entity_load_unchanged($entity_type, $id) {
- *   the entity storage's delete() method to delete multiple entities:
+ *   the entity storage's \Drupal\Core\Entity\EntityStorageInterface::delete() method to delete multiple entities:

I think this needs to break at 80 characters for phpcs, i.e method onwards would be on another new line

pameeela’s picture

pameeela CreditAttribution: pameeela commented
FileSize
3051932-5.patch706 bytes

Ahh thanks figured I would be missing something!

pameeela’s picture

pameeela CreditAttribution: pameeela commented
FileSize
3051932-6.patch713 bytes

This time with the correct patch.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/includes/entity.inc
@@ -233,7 +233,8 @@ function entity_load_unchanged($entity_type, $id) {
+ *   the entity storage's \Drupal\Core\Entity\EntityStorageInterface::delete() ¶

there's some whitespace on the end of the line here that can be fixed on commit

  • catch committed 2dff22c on 8.9.x 
    Issue #3051932 by pameeela, larowlan, aurelianzaha: Update docs link to...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 2dff22c and pushed to 8.9.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.