Keep running tests checked

This would be a lovely, lovely thing full of loveliness.

Sorry for changing the issue title, but I feel that my patch belongs in this issue. It depends on #308668: Make test selection page work with non-JS and #308719: Sanitize simpletest.js checkbox code. Instead of preserving the "checked" status for failed tests only, it selects all tests that have run before.

The reason is that I as developer want to run the same test over and over again, because
a) I'm only just writing the patch and want to execute it multiple times.
b) I'm running the same test on the working (current) and not-yet-working (patched) Drupal, and after doing the first run I want to run the same set of tests in my patched version that I previously selected.

Unchecking is easy and a one-time operation, whereas checking that stuff each time is tedious. Perhaps labels of failed tests could be painted in error colors in order to more easily distinguish which ones to disable (in order to accomodate the original proposal), but I think all previous tests should be enabled again by default.

Anyways, whatever the outcome, it shouldn't be difficult to take this patch into some slightly different direction. Please review! Thanks.

Dude! I told you that it depends on those other patches!

Bots.

Rerolled for current HEAD - the previously committed patch from #308272: Improve test selection page caused quite a few failed hunks. With #308668: Make test selection page work with non-JS having been committed, this should apply again too, so let's see if the bot likes "code needs review" better this time. (In order to work properly, the fixes from #308719: Sanitize simpletest.js checkbox code are still required.)

That or we can use the approach in #250047: Rework the SimpleTest results interface and clean-up of backend code

I would recommend remembering the failed tests only, that's the workflow, isnt it -- run all tests, try N times fixing failed ones, and at the end run all of them again.

Yes but that's somewhat confusing, even that's what most people want.

Yeah, I agree. Keep the existing ones checked. If there are fails, I would go and uncheck the ones I didn't want and then keep that behaviour. In fact, more often than not, I'd want to keep running the entire subset of a given area I'm working on even if there were passes in the first iteration of my patch.

Also, I can't begin to express how much I would love to see this in UNSTABLE-3. This is the bane of my existence, and actively holds up testers.

+1 for keeping passing tests too. Sometimes I'll run a test just before I think I'm about to break it for example.

Er, dude? This still applies, even if it's with 3 lines offset per hunk.
Apart from that, nice to see so much interest in this :) just remember that this depends on #308719: Sanitize simpletest.js checkbox code which needs to go in first (and is currently in need of a review).

Committed to CVS HEAD. Thanks.

Thanks. The test-group checkboxes are still supposed to be buggy due to the other patch not yet committed, but I guess it's better this way than before :)