Not sure what the process now exactly is for PHP 5 problems, but I hope it is not necessary to revert the patch that caused it, which was #3035953: Add @trigger_error() to deprecated EntityManager->EntityFieldManager methods I suppose.

CommentFileSizeAuthor
#4 entity-field-manager-conflict-3051255-4.patch1.14 KBBerdir
#2 entity-field-manager-conflict-3051255-2.patch634 bytesBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Active » Needs review
FileSize
entity-field-manager-conflict-3051255-2.patch634 bytes

See https://www.drupal.org/pift-ci-job/1274211. Not sure if this is the only one.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work

Parse error: syntax error, unexpected 'function' (T_FUNCTION), expecting identifier (T_STRING) or \\ (T_NS_SEPARATOR) in /var/www/html/core/tests/Drupal/KernelTests/Core/Entity/EntityLegacyTest.php on line 11

That's "use function entity_get_display;", I guess that got in there accidently when adding those tests, that's from the entity_get_display() issue.

Will update the patch when I can but just needs that line removed.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
entity-field-manager-conflict-3051255-4.patch1.14 KB

This should also pass on 5.5 I think.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Title: Conflict between EntityField and FieldAPIHandlerTrait on PHP5 » Conflict between EntityField and FieldAPIHandlerTrait on PHP 5

  • Gábor Hojtsy committed f91dd64 on 8.8.x 
    Issue #3051255 by Berdir, larowlan: Conflict between EntityField and...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Fixed

Whoops, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.