Problem/Motivation

BcRoutesTest makes no HTTP requests but is a functional test

Proposed resolution

Convert BcRoutesTest into a Kernel test

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#2 3046698-2.patch1.12 KBclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status: Active » Needs review
FileSize
3046698-2.patch1.12 KB

This patch decreases the locally test run from 7.0 to 1.4 seconds.

Status: Needs review » Needs work

The last submitted patch, 2: 3046698-2.patch, failed testing. View results

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status: Needs work » Needs review

Unrelated failure.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at ezCompany commented
Status: Needs review » Reviewed & tested by the community

Straight forward, looks good.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 61d89c6 and pushed to 8.8.x. Thanks!

  • catch committed 61d89c6 on 8.8.x 
    Issue #3046698 by claudiu.cristea: Convert BcRoutesTest into a Kernel...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.