Problem/Motivation

NewDefaultThemeBlocksTest makes no HTTP requests but is a functional test

Proposed resolution

Convert NewDefaultThemeBlocksTest into a Kernel test

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#4 3046680-4.patch4.4 KBclaudiu.cristea
#4 3046680-4.interdiff.txt761 bytesclaudiu.cristea
#2 3046680-2.patch4.4 KBclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status: Active » Needs review
FileSize
3046680-2.patch4.4 KB

This patch decreases the locally test run from 6.3 to 1.3 seconds.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at ezCompany commented 
+++ b/core/modules/block/tests/src/Kernel/NewDefaultThemeBlocksTest.php
@@ -1,76 +1,86 @@
-    // Ensure that the new theme has all the blocks as the previous default.
+    // Ensure that the new default theme has all the blocks as the previous

I don't think this is or was proper english? Not sure, might be valid.
"Ensure that the new default theme has the same blocks as the previous default theme."

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
FileSize
3046680-4.interdiff.txt761 bytes
3046680-4.patch4.4 KB

Fixed the docs.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at ezCompany commented
Status: Needs review » Reviewed & tested by the community

Thanks for fixing, no more nits to pick from me.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed c8ef0bb and pushed to 8.8.x. Thanks!

  • catch committed c8ef0bb on 8.8.x 
    Issue #3046680 by claudiu.cristea, Lendude: Convert...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.