Problem/Motivation

Methods in \Drupal\Component\Plugin\ContextAwarePluginInterface say they throw \Drupal\Component\Plugin\Exception\PluginException but actually throw \Drupal\Component\Plugin\Exception\ContextException.

Proposed resolution

Update the @throws docs

Remaining tasks

User interface changes

N/A

API changes

Not really? Idk if this counts

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#18 interdiff-14-18.txt519 bytespragati_kanade
#18 Update_throws_docblock-3046342-18.patch3.99 KBpragati_kanade
#14 Update_throws_docblock-3046342-14.patch4.04 KBpragati_kanade
#14 interdiff-9-14.txt524 bytespragati_kanade
#10 interdiff_4-9.txt2.54 KBpragati_kanade
#10 Update_throws_docblock-3046342-9.patch4.04 KBpragati_kanade
#4 Update_throws_docblock-3046342-4.patch .diff1.47 KBthomscode
#3 Update_throws_docblock-3046342-3.patch .diff742 bytesthomscode

Issue fork drupal-3046342

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett created an issue. See original summary.

thomscode’s picture

thomscode CreditAttribution: thomscode at Pacific Northwest National Laboratory commented

Working on this.
#DrupalConSeattle
#DrupalCon2019

thomscode’s picture

thomscode CreditAttribution: thomscode at Pacific Northwest National Laboratory commented
FileSize
Update_throws_docblock-3046342-3.patch .diff742 bytes

Patch changes the exception type.

thomscode’s picture

thomscode CreditAttribution: thomscode at Pacific Northwest National Laboratory commented
FileSize
Update_throws_docblock-3046342-4.patch .diff1.47 KB

Fixed a second class with the incorrect @throw exception type.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented

There are still multiple remaining PluginException usages in those interfaces.
Also, please remove the @todo linking to this issue in ContextHandler.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

pragati_kanade’s picture

pragati_kanade CreditAttribution: pragati_kanade at QED42 for Drupal India Association commented
Assigned: Unassigned » pragati_kanade
pragati_kanade’s picture

pragati_kanade CreditAttribution: pragati_kanade at QED42 for Drupal India Association commented
FileSize
Update_throws_docblock-3046342-9.patch4.04 KB
interdiff_4-9.txt2.54 KB
pragati_kanade’s picture

pragati_kanade CreditAttribution: pragati_kanade at QED42 for Drupal India Association commented
Assigned: pragati_kanade » Unassigned
Status: Active » Needs review
AJV009’s picture

AJV009
Primary language English
Location Maharashtra
CreditAttribution: AJV009 as a volunteer and at QED42 for Drupal India Association commented
Status: Needs review » Needs work

(test failed)
Remove Whitespace found at end of line 124 in /core/lib/Drupal/Core/Plugin/Context/ContextHandler.php

pragati_kanade’s picture

pragati_kanade CreditAttribution: pragati_kanade at QED42 for Drupal India Association commented
Assigned: Unassigned » pragati_kanade
pragati_kanade’s picture

pragati_kanade CreditAttribution: pragati_kanade at QED42 for Drupal India Association commented
FileSize
interdiff-9-14.txt524 bytes
Update_throws_docblock-3046342-14.patch4.04 KB
pragati_kanade’s picture

pragati_kanade CreditAttribution: pragati_kanade at QED42 for Drupal India Association commented
Status: Needs work » Needs review
pragati_kanade’s picture

pragati_kanade CreditAttribution: pragati_kanade at QED42 for Drupal India Association commented
Assigned: pragati_kanade » Unassigned
pragati_kanade’s picture

pragati_kanade CreditAttribution: pragati_kanade at QED42 for Drupal India Association commented
Assigned: Unassigned » pragati_kanade
pragati_kanade’s picture

pragati_kanade CreditAttribution: pragati_kanade at QED42 for Drupal India Association commented
FileSize
Update_throws_docblock-3046342-18.patch3.99 KB
interdiff-14-18.txt519 bytes
nishantghetiya’s picture

nishantghetiya CreditAttribution: nishantghetiya as a volunteer and at QED42 for Drupal India Association commented
Status: Needs review » Reviewed & tested by the community

Patch applied and reviewed successfully.

  • catch committed bd43d47 on 9.2.x 
    Issue #3046342 by pragati_kanade, thomscode, tim.plunkett: \Drupal\...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed bd43d47 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.