Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Symfony 3.4.24 has been released - https://symfony.com/blog/symfony-3-4-24-released
Twig 1.
Doing this makes 8.7.0 release the same for tarball users and composer users.
Proposed resolution
Run composer update "symfony/*" "twig/*"
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
Release notes snippet
Symfony components updated to 3.4.24
Comment | File | Size | Author |
---|---|---|---|
#2 | 3045967-2.patch | 24.21 KB | alexpott |
Comments
Comment #2
alexpottAfter doing the update. On PHP 5.5
The html5 is a known issue.
Twig worries me because of things like #3045826: Issues After Twig updated to 1.38.4
Comment #3
cilefen CreditAttribution: cilefen commentedThere is a core issue too #3040269: Twig\Error\SyntaxError: An exception has been thrown during the compilation of a template ("Attribute "name" does not exist for Node "Twig\Node\CheckToStringNode".
Comment #4
mikelutzI do not believe that Twig 1.38.4 introduces any more issues than Twig 1.38.2. I have read through the various complaints on 1.38.4, and I can't find a single example where someone has stated specifically that they had no issues with 1.38.2 and 8.6.12 then updated twig to 1.38.4 and started having problems. #3045826: Issues After Twig updated to 1.38.4 complains about the error everybody is seeing, "("Attribute "name" does not exist for Node "Twig\Node\CheckToStringNode".") but doesn't specifically state which version of twig they are coming from. My suspicion is they upgraded directly to 1.38.4, but there is no way to tell. I just postponed that issue to get more info. #3040269: Twig\Error\SyntaxError: An exception has been thrown during the compilation of a template ("Attribute "name" does not exist for Node "Twig\Node\CheckToStringNode" provides many more examples of the 'name does not exist' error, but none of them seem to have started during an upgrade from 1.38.2 to 1.38.4. I just closed that thread because every instance of the error reported could be traced back to either a custom module or theme overriding core's %trans% code that needs the same modifications we made in core, or someone who had not yet updated to 8.6.12 and gotten the core fix. (And I believe when we get more info on 3045826, we will trace that back to one of the two situations as well)
I do know that 1.38.4 fixed some bugs that have been giving contrib some trouble, specifically devel's twig breakpoint code. See #3040310: devel_breakpoint() and kint() are broken with twig/twig < 1.38.4 for the devel issue (They overrode drupalci.yml to upgrade twig to 1.38.4 for the moment just to get their test suite to pass) Also see https://github.com/twigphp/Twig/issues/2908 for a discussion of the issue in the Twig issue queue that was fixed in 1.38.4. It's an obvious bugfix, and not something that should introduce any additional 'name does not exist' errors that weren't already there. Finally, #3044155: PHP7.1 vendor max Testing issue - DO NOT COMMIT, (which simply is an issue that runs a full
composer update
prior to running the test suite) Is not currently finding any issues around any currently available vendor updates, including twig 1.38.4 or Symfony 3.4.24 since we fixed the symfony issues yesterday.Comment #5
jibranComment #6
catch+1. Better to update now than a patch release.
Comment #7
catchA lot of failures like this on PHP 5.5, sent for a re-test:
Committing anyway because we no longer support PHP 5.5, but interested to see if those are repeatable.
Committed 0104d18 and pushed to 8.8.x, then cherry-picked to 8.7.x. Thanks!
Comment #10
jibranAdded #3048569: Update PHP dependencies for 8.7.x to update symfony verison to v3.4.25 and twig to v1.39.0.