See our testbot run that fails currently.
https://www.drupal.org/pift-ci-job/1242435

CommentFileSizeAuthor
#9 interdiff-3043800-7-9.txt573 bytesjohnchque
#9 cleanup_applyupdates-3043800-9.patch819 bytesjohnchque
#7 interdiff-3043800-6-7.txt572 bytesjohnchque
#7 cleanup_applyupdates-3043800-7.patch817 bytesjohnchque
#6 interdiff-3043800-2-6.txt632 bytesjohnchque
#6 cleanup_applyupdates-3043800-6.patch818 bytesjohnchque
#2 cleanup_applyupdates-3043800-2.patch634 bytesjohnchque
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

miro_dietiker created an issue. See original summary.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Active » Needs review
FileSize
cleanup_applyupdates-3043800-2.patch634 bytes

I believe that we don't need this anymore as it is in the demo module?

Status: Needs review » Needs work

The last submitted patch, 2: cleanup_applyupdates-3043800-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Category: Bug report » Task
Priority: Normal » Critical

I think we need to wait for the next stable release to ave it working again. Alternatively we could maybe figure out the version and only call it if below 8.6.14. Requesting retests from all dev branches.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

actually, it is only fixed in 8.7 according to the test fails, but it is also only 8.7 that complains about this, so lets wrap it inside a version_compare(\Drupal::VERSION, '8.7.0', '<=').

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
cleanup_applyupdates-3043800-6.patch818 bytes
interdiff-3043800-2-6.txt632 bytes

That's true. Thank you @Berdir!

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
FileSize
cleanup_applyupdates-3043800-7.patch817 bytes
interdiff-3043800-6-7.txt572 bytes

I believe we need to do this for < 8.7.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work 
+++ b/modules/paragraphs_demo/paragraphs_demo.install
@@ -13,8 +13,10 @@ use Drupal\workflows\Entity\Workflow;
-  // Ensure the translation fields are created in the database.
-  \Drupal::service('entity.definition_update_manager')->applyUpdates();
+  if (version_compare(\Drupal::VERSION, '8.7.0', '<')) {
+    // Ensure the translation fields are created in the database.
+    \Drupal::service('entity.definition_update_manager')->applyUpdates();
+  }

This doesn't work because 8.7.0-dev is < 8.7.0.

But we can use '8.6.99' instead, it is quite likely that there will never be more than 99 versions of 8.6 ;)

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
cleanup_applyupdates-3043800-9.patch819 bytes
interdiff-3043800-7-9.txt573 bytes

Haha that's true. :) Thanks.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Great, committed this, thx!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.