Problem/Motivation

Currently the modules page capitalises the first letter of missing dependency machine names.

I'm referring to contributed module paragraphs_library as an example to describe this issue:

capitalised first letter missing dependency

Description: Provides a library for reusing paragraphs.
Machine name: paragraphs_library
Requires: Paragraphs, Entity Reference, Revisions, File, Field, System, Views, Filter, User, Entity_usage (missing)
Required by: Paragraphs Demo (disabled)

As can be seen, the Entity_usage (missing) module is ran through ucfirst() before it is rendered on the page.

Proposed resolution

The actual module title for these missing dependencies cannot be retrieved or assumed, so for consistency reasons I believe they should be listed in lowercase.

Remaining tasks

Reviews needed

User interface changes

Modules will show missing dependencies as lowercased

API changes

None

Data model changes

None

Release notes snippet

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

baikho created an issue. See original summary.

baikho’s picture

Issue summary: View changes
baikho’s picture

baikho’s picture

Status: Active » Needs review
mpp’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, thanks!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

We had some kind of thought process about this before, but I agree that there's a lack of consistency and just looks kinda weird. So this change looks good to me!

This also resulted in a warning about an unused use statement (use Drupal\Component\Utility\Unicode;) so removed that as well. (Yay less code!)

Committed and pushed to 8.8.x, thanks!

  • webchick committed 473ae84 on 8.8.x
    Issue #3042999 by baikho, mpp: Remove ucfirst() from missing...

  • webchick committed 19fe4f9 on 8.8.x
    Issue #3042999: Remove unused use statement.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.