Problem/Motivation
Currently the modules page capitalises the first letter of missing dependency machine names.
I'm referring to contributed module paragraphs_library
as an example to describe this issue:
Description: Provides a library for reusing paragraphs.
Machine name: paragraphs_library
Requires: Paragraphs, Entity Reference, Revisions, File, Field, System, Views, Filter, User, Entity_usage (missing)
Required by: Paragraphs Demo (disabled)
As can be seen, the Entity_usage (missing) module is ran through ucfirst()
before it is rendered on the page.
Proposed resolution
The actual module title for these missing dependencies cannot be retrieved or assumed, so for consistency reasons I believe they should be listed in lowercase.
Remaining tasks
Reviews needed
User interface changes
Modules will show missing dependencies as lowercased
API changes
None
Data model changes
None
Release notes snippet
None
Comment | File | Size | Author |
---|---|---|---|
#3 | capitalised-first-letter-missing-dependency.png | 56.15 KB | baikho |
drupal-capitalised_first_letter_missing_depependencies-1.patch | 929 bytes | baikho | |
Comments
Comment #2
baikhoComment #3
baikhoComment #4
baikhoComment #5
mpp CreditAttribution: mpp at AmeXio for District09 commentedLooks good, thanks!
Comment #6
webchickWe had some kind of thought process about this before, but I agree that there's a lack of consistency and just looks kinda weird. So this change looks good to me!
This also resulted in a warning about an unused use statement (use Drupal\Component\Utility\Unicode;) so removed that as well. (Yay less code!)
Committed and pushed to 8.8.x, thanks!