After reading README.txt I have found a few minor issues related to word duplication and punctuation.

Release notes snippet

Minor edits in core/README.txt.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RuslanP created an issue. See original summary.

Ruslan Piskarov’s picture

eslamhiko’s picture

Status: Needs review » Reviewed & tested by the community

Patch review :

- Is the patch secure? : yes
- Are the theme functions/files in the proper place? : yes
- Is it a "stinky?"? : no
- Does it duplicate code? : no
- Is the code efficient? : yes
- Are the patch's tests sufficient? : yes
- Does the patch implements useful tweaks brought up in the discussion? : yes

This patch is working without any issues

note: it's my first comment on the Drupal community I'm very new to open source contribution

cilefen’s picture

Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Needs work

Welcome @eslamhiko! Thank you @RuslanP.

I looked over this patch and I have some comments below on how to improve it.

In this case "core" is a Drupal-ism, and a proper noun. We do not refer to it as "the" core. It is usually referred to as "Drupal Core". That would be clearer here.

@@ -52,7 +52,7 @@ INSTALLATION PROFILES
 
 Installation profiles define additional steps (such as enabling modules,
 defining content types, etc.) that run after the base installation provided
-by core when Drupal is first installed. There are two basic installation
+by the core when Drupal is first installed. There are two basic installation
 profiles provided with Drupal core.

The first added comma below is not proper punctuation. The second comma is optional, but it is ok.

@@ -391,7 +391,7 @@ MULTISITE CONFIGURATION
 A single Drupal installation can host several Drupal-powered sites, each with
 its own individual configuration.
 
-For this to work you need the file sites/sites.php to exist. Make a copy of
+For this, to work, you need the file sites/sites.php to exist. Make a copy of
 the example.sites.php file:

@eslamhiko:

There are a number of review guides and also a list of core "gates" we refer to before committing changes. Please join the Drupal community on Slack to get more involved. I'd be happy to suggest some issues to work on if you ping me there.

(edited)

Ruslan Piskarov’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
1.02 KB

Thank you @cilefen. Left only two edits in the sentences.

Ruslan Piskarov’s picture

Version: 8.7.x-dev » 8.8.x-dev
sime’s picture

Patch applies cleanly and text reads well to me.

cilefen’s picture

Version: 8.8.x-dev » 8.7.x-dev

Please leave the version.

cilefen’s picture

Category: Task » Bug report

Please leave the version.

jds1’s picture

Patch applies to 8.7.0-beta2 but I am also seeing an issue where we are trying to change txt files to md files for a better GitLab experience. https://www.drupal.org/project/drupal/issues/3044974.

Should we change this to readme.md here as well?

cilefen’s picture

@if-jds That would be out of scope: https://www.drupal.org/core/scope

sime’s picture

Status: Needs review » Reviewed & tested by the community

Multiple eye balls. Minor docs patch. RTBC.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Crediting @cilefen for issue review comments that influenced the patch and @eslamhiko for a first time review comment that documented exactly what they did.

Committed and pushed 9c0d62712b to 8.8.x and ca13d81739 to 8.7.x. Thanks!

  • alexpott committed 9c0d627 on 8.8.x
    Issue #3042882 by RuslanP, cilefen, eslamhiko: Word duplication and...

  • alexpott committed ca13d81 on 8.7.x
    Issue #3042882 by RuslanP, cilefen, eslamhiko: Word duplication and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.