Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After reading README.txt I have found a few minor issues related to word duplication and punctuation.
Release notes snippet
Minor edits in core/README.txt.
Comment | File | Size | Author |
---|---|---|---|
#5 | word-duplication-and-punctuation-readme-3042882-5.patch | 1.02 KB | Ruslan Piskarov |
Comments
Comment #2
Ruslan PiskarovComment #3
eslamhiko CreditAttribution: eslamhiko at Google Summer of Code commentedPatch review :
- Is the patch secure? : yes
- Are the theme functions/files in the proper place? : yes
- Is it a "stinky?"? : no
- Does it duplicate code? : no
- Is the code efficient? : yes
- Are the patch's tests sufficient? : yes
- Does the patch implements useful tweaks brought up in the discussion? : yes
This patch is working without any issues
note: it's my first comment on the Drupal community I'm very new to open source contribution
Comment #4
cilefen CreditAttribution: cilefen as a volunteer commentedWelcome @eslamhiko! Thank you @RuslanP.
I looked over this patch and I have some comments below on how to improve it.
In this case "core" is a Drupal-ism, and a proper noun. We do not refer to it as "the" core. It is usually referred to as "Drupal Core". That would be clearer here.
The first added comma below is not proper punctuation. The second comma is optional, but it is ok.
@eslamhiko:
There are a number of review guides and also a list of core "gates" we refer to before committing changes. Please join the Drupal community on Slack to get more involved. I'd be happy to suggest some issues to work on if you ping me there.
(edited)
Comment #5
Ruslan PiskarovThank you @cilefen. Left only two edits in the sentences.
Comment #6
Ruslan PiskarovComment #7
simePatch applies cleanly and text reads well to me.
Comment #8
cilefen CreditAttribution: cilefen as a volunteer commentedPlease leave the version.
Comment #9
cilefen CreditAttribution: cilefen as a volunteer commentedPlease leave the version.
Comment #10
jds1Patch applies to 8.7.0-beta2 but I am also seeing an issue where we are trying to change txt files to md files for a better GitLab experience. https://www.drupal.org/project/drupal/issues/3044974.
Should we change this to readme.md here as well?
Comment #11
cilefen CreditAttribution: cilefen as a volunteer commented@if-jds That would be out of scope: https://www.drupal.org/core/scope
Comment #12
simeMultiple eye balls. Minor docs patch. RTBC.
Comment #13
alexpottCrediting @cilefen for issue review comments that influenced the patch and @eslamhiko for a first time review comment that documented exactly what they did.
Committed and pushed 9c0d62712b to 8.8.x and ca13d81739 to 8.7.x. Thanks!