Problem/Motivation

drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/imageapi_optimize 3daf4e61ede57598a9b9b6f1568bc6b146846704
source : http://cgit.drupalcode.org/imageapi_optimize 


 ------ --------------------------------------------------- 
  Line   src/Form/ImageAPIOptimizePipelineAddForm.php       
 ------ --------------------------------------------------- 
  17     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/ImageAPIOptimizePipelineEditForm.php      
 ------ --------------------------------------------------- 
  221    Call to deprecated function drupal_set_message().  
  244    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/ImageAPIOptimizePipelineFlushForm.php     
 ------ --------------------------------------------------- 
  38     Call to deprecated method urlInfo() of class       
         Drupal\Core\Entity\EntityInterface.                
  46     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ----------------------------------------------- 
  Line   src/Form/ImageAPIOptimizePipelineFormBase.php  
 ------ ----------------------------------------------- 
  76     Call to deprecated method urlInfo() of class   
         Drupal\Core\Entity\EntityInterface.            
 ------ ----------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/ImageAPIOptimizeProcessorDeleteForm.php   
 ------ --------------------------------------------------- 
  46     Call to deprecated method urlInfo() of class       
         Drupal\Core\Entity\EntityInterface.                
  71     Call to deprecated function drupal_set_message().  
  72     Call to deprecated method urlInfo() of class       
         Drupal\Core\Entity\EntityInterface.                
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/ImageAPIOptimizeProcessorFormBase.php     
 ------ --------------------------------------------------- 
  95     Call to deprecated method urlInfo() of class       
         Drupal\Core\Entity\EntityInterface.                
  126    Call to deprecated function drupal_set_message().  
  127    Call to deprecated method urlInfo() of class       
         Drupal\Core\Entity\EntityInterface.                
 ------ --------------------------------------------------- 

 ------ ---------------------------------------------- 
  Line   src/ImageAPIOptimizePipelineListBuilder.php   
 ------ ---------------------------------------------- 
  75     Call to deprecated method urlInfo() of class  
         Drupal\Core\Entity\EntityInterface.           
 ------ ---------------------------------------------- 

 [ERROR] Found 13 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 drupal_9_deprecated_code-3042800-2.patch6.33 KBSergiu Stici
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mcdwayne created an issue. See original summary.

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Active » Needs review
FileSize
drupal_9_deprecated_code-3042800-2.patch6.33 KB

Here is the patch, please review.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Needs review » Needs work

Thanks very much for the patch, but I think that ImageAPIOptimizePipelineFormBase will need to include the Drupal\Core\Messenger\MessengerTrait as per https://www.drupal.org/node/2774931 ?

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Needs work » Needs review

Take my comment back, the trait is in FormBase, isn't it?

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones at ComputerMinds commented
Status: Needs review » Fixed

Thanks very much for the patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.