Problem/Motivation

[COMMIT_HASH]
52e1c78b2379b24aed478b6e0544ff7c89f7a5d6
[RESULTS_OUTPUT]
[OK] No errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 menu_block_drupal9.patch325 bytesmatsbla
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Adrianm6254 created an issue. See original summary.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton at Jeneration Web Development for Metropolitan Transportation Commission commented
Status: Active » Fixed

If there are no errors, can this issue can be marked as fixed?

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton at Jeneration Web Development for Metropolitan Transportation Commission commented
Status: Fixed » Active

or actually...

I believe that if you add drupal 9 as an option to the composer.json file in this project you can get a nice little Compatible with Drupal 9 badge in the Project information section on the module page.

Screenshot of the Project information section with Compatible with Drupal 9 highlighted

Below is a code sample from a module that has the badge.

"require": {
        "php": "^7.1",
       "drupal/core": "^8 || ^9"
  },

It also looks like it may possible to get the badge by adding the 'core_version_requirement' key in the modules info.yml file, which, in turn, will add the version to the require section of composer.json. Example follows.

core_version_requirement: ^8 || ^9

We should maybe make a patch for this change.

matsbla’s picture

matsbla CreditAttribution: matsbla at Globalbility commented
FileSize
menu_block_drupal9.patch325 bytes
matsbla’s picture

matsbla CreditAttribution: matsbla at Globalbility commented
Status: Active » Needs review
jayasree.e’s picture

jayasree.e CreditAttribution: jayasree.e as a volunteer and at TA Digital commented
Status: Needs review » Reviewed & tested by the community

Thanks. Looks good to me.

xeM8VfDh’s picture

xeM8VfDh CreditAttribution: xeM8VfDh commented

can this change be merged and closed?

As for the badge, a core maintainer has informed me that composer.yml and info.yml don't come into play. There is some text field that the module maintainer has access to that allows them to mark the module as D9 compatible, which will cause the badge to show.

  • joelpittet committed 461cf33 on 8.x-1.x authored by matsbla 
    Issue #3042653 by matsbla, jenlampton: Drupal 9 Deprecated Code Report
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Thank you I've committed this to the dev version.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.