Another child of #2886622: Deprecate all EntityManager methods with E_USER_DEPRECATED, now that all the non entity manager methods are done, this addressed the last remaining injected instances of entity manager -> entity type manager.

This is on top of #3035953: Add @trigger_error() to deprecated EntityManager->EntityFieldManager methods, so not sure if it will apply.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

... not sure what happend with that patch.

martin107’s picture

Status: Needs review » Reviewed & tested by the community

Wow almost a 90k patch

After a slow visual scan ...

a) DeprecatedServicePropertyTrait everywhere I expected
b) all @param definitions updated -- consistently.
c) patch contains only changes aimed at solving the problem
d) no extra coding standard changes lurking in the test results.

FWIW I agree with the idea behind this patch... this is a good cleanup.

andypost’s picture

Status: Reviewed & tested by the community » Needs review

+1 to get this in while beta

andypost’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +@deprecated
larowlan’s picture

Status: Reviewed & tested by the community » Fixed

Committed 12d7ed5 and pushed to 8.8.x. Thanks!

  • larowlan committed 12d7ed5 on 8.8.x
    Issue #3042545 by Berdir, martin107: Update last injected entity...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.