Problem/Motivation

Delete double ";;"

Proposed resolution

Enable the Generic.CodeAnalysis.EmptyPHPStatement PHPCS sniff for this

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

Generic.CodeAnalysis.EmptyPHPStatement enabled in phpcs.xml to prevent empty PHP statements.

CommentFileSizeAuthor
#6 3041985-6.patch16.62 KBalexpott
#6 3-6-interdiff.txt5.32 KBalexpott
#3 core_double-3041985-3.patch12.53 KBpifagor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pifagor created an issue. See original summary.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor as a volunteer and at EPAM Systems, Drupal Ukraine Community, GOLEMS GABB for EPAM Systems, GOLEMS GABB, Drupal Ukraine Community commented
Assigned: Unassigned » pifagor
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor as a volunteer and at EPAM Systems for EPAM Systems commented
Assigned: pifagor » Unassigned
Status: Active » Needs review
FileSize
core_double-3041985-3.patch12.53 KB
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented
Status: Needs review » Reviewed & tested by the community

Interesting. Looks good for me.
Wondering can we add the codesniffer rule for such a situation for Drupal coder?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Thunder commented
Status: Reviewed & tested by the community » Needs work

There is a code sniffer thing for this already.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Thunder commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Needs work » Needs review
FileSize
3-6-interdiff.txt5.32 KB
3041985-6.patch16.62 KB

As a coding standard rule change targeting 8.7.x beta.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Thunder commented
Title: Delete double ";;" » Add Generic.CodeAnalysis.EmptyPHPStatement to phpcs rules to prevent empty PHP statements
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor as a volunteer and at Drupal Ukraine Community, GOLEMS GABB for Drupal Ukraine Community, GOLEMS GABB commented
Status: Needs review » Reviewed & tested by the community

Looks good for me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott as a volunteer and at Thunder commented
Issue summary: View changes

  • catch committed f2eaf01 on 8.8.x 
    Issue #3041985 by alexpott, pifagor: Add Generic.CodeAnalysis....

  • catch committed 0188838 on 8.7.x 
    Issue #3041985 by alexpott, pifagor: Add Generic.CodeAnalysis....
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.8.x and cherry-picked to 8.7.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.