Drupal 9 Deprecated Code Report

@josephdpurcell could you run that against dev? I think half of those are fixed.

Thanks you, did you want to tackle those?

Is this part of a master plan for D9 @benjifisher?

@joelpittet:

The immediate plan is to kick-start the process during the contribution day (tomorrow, 2019-03-23) at MidCamp. We plan to generate a lot of reports like the one in the IS here. For now, we want to get an idea of how much work there is to be done.

Once we get through the list of the 100 most-installed modules, maybe we will have time to start fixing the deprecations.

To find the other issues, search for the issue tag: Drupal 9 compatibility.

Thanks @benjifisher for bringing me up-to-date.

Follow the patch!

@thalles have a look at the docblock above assertFieldByXPath it will give you hints how to do it. For all of those because the value is NULL you can do something like this:

$fields = $this->xpath($xpath);
$this->assertTrue($fields);

Would it be this?

     $fields = $this->xpath('//input[@type="number" and @name="settings[override][pager_offset]"]');
    $this->assertTrue($fields, 'items_per_page setting is a number field');

I believe so, yes, give that a try for all of those.

Follow the patch!

Follow the most complete patch!

+++ b/modules/ctools_views/src/Tests/CToolsViewsBasicViewBlockTest.php
@@ -262,23 +262,23 @@ class CToolsViewsBasicViewBlockTest extends UITestBase {
-    $this->assertEqual(-46, $config['fields']['id']['weight'], "'sort_fields' setting is properly saved.");
-    $this->assertEqual(-50, $config['fields']['name']['weight'], "'sort_fields' setting is properly saved.");
+    $this->assertEquals($config['fields']['id']['weight'], "'sort_fields' setting is properly saved.", -46);
+    $this->assertEquals($config['fields']['name']['weight'], "'sort_fields' setting is properly saved.", -50);

These ones the expected value is in argument 3 instead of 2

I'm not sure about the page 1 response, maybe it's in an attribute of an HTML tag or something?

Re #17 it looks like that was fixed on #3043399: Replace deprecated assertEqual() in CToolsViewsBasicViewBlockTest file already, rerolling.

Also fixing my own review while I was at it:

+++ b/modules/ctools_views/src/Tests/CToolsViewsBasicViewBlockTest.php
@@ -300,8 +300,8 @@ class CToolsViewsBasicViewBlockTest extends UITestBase {
-    $this->assertFieldByXPath('//select[@name="status"]');
-    $this->assertFieldByXPath('//input[@name="job"]');
+    $this->assertTrue($this->xpath('//select[@name="status"]'));
+    $this->assertTrue($this->xpath('//input[@name="job"]'));

@@ -329,7 +329,7 @@ class CToolsViewsBasicViewBlockTest extends UITestBase {
-    $this->assertFieldByXPath('//input[@name="settings[override][sort][id][order]"]');
+    $this->assertTrue($this->xpath('//input[@name="settings[override][sort][id][order]"]'));

I believe these should rather use $this->assertSession()->fieldExists()

Jesus, wrong patches sorry.

We should also use pageTextNotContains since we're checking for text only.

1) Drupal\ctools_views\Tests\CToolsViewsBasicViewBlockTest::testPager
Behat\Mink\Exception\ResponseTextException: The text "Page 1" appears in the text of this page, but it should not.

Test needs adjustment because its picking up the valid text:
Displaying 1 - 3 of 5 Showing 3 records on page 1

In reality what we're trying to do here is assert that the pager isn't displayed, so I propose we check the existence of the element itself.

Looks good!

Thanks all, I've committed this to the latest dev branch.