Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
UserMailNotifyTest
is Kernel test but for some reason wrongly lives under Functional tests namespace.
Proposed resolution
Move UserMailNotifyTest
under Kernel tests namespace.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
N/A
Comment | File | Size | Author |
---|---|---|---|
#4 | 3041816-4.patch | 3.82 KB | claudiu.cristea |
Comments
Comment #2
claudiu.cristeaPatch.
Comment #3
LendudeOops, nice catch.
Couple of things we can clean up/make better while we are touching this:
$mail_keys isn't used in testUserMailsNotSent so we can remove that.
Another good addition would be to add array keys to the array returned by userMailsProvider so we PHPUnit gives clearer feedback about which dataset it is working on.
Comment #4
claudiu.cristeaAgree.
Comment #5
LendudeNice, looks ready to me.
Comment #6
alexpottCommitted and pushed d88a43d47f to 8.8.x and 4c59167cb5 to 8.7.x. Thanks!
As a test only change backported to 8.7.x - I discussed backporting test-only changes with @catch (as a release manager).
Personally I think for assertNull and assertTrue messages are a bit more useful but also at the end of the day if an assertion fails you always have to look at the test so /shrug.