Problem/Motivation

ViewRenderTest makes no HTTP request but is a functional test.

Proposed resolution

Convert ViewRenderTest into a Kernel test.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

CommentFileSizeAuthor
#5 3041727-5.patch1.56 KBManuel Garcia
#5 interdiff-3041727-2-5.txt468 bytesManuel Garcia
#2 3041727-2.patch1.58 KBclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status: Active » Needs review
FileSize
3041727-2.patch1.58 KB

Patch.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Parent issue: » #3041700: [META] Convert some tests into Kernel or Unit tests
amateescu’s picture

amateescu CreditAttribution: amateescu commented 
+++ b/core/modules/views/tests/src/Kernel/ViewRenderTest.php
@@ -2,6 +2,7 @@
 namespace Drupal\Tests\views\Functional;

Forgot to update the namespace :)

Manuel Garcia’s picture

Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation commented
FileSize
interdiff-3041727-2-5.txt468 bytes
3041727-5.patch1.56 KB

Addressing #4

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs review » Reviewed & tested by the community

Looks good!

The last submitted patch, 2: 3041727-2.patch, failed testing. View results

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 9e5e613d42 to 8.8.x and 271932a321 to 8.7.x. Thanks!

As a test only change backported to 8.7.x - I discussed backporting test-only changes with @catch (as a release manager).

  • alexpott committed 9e5e613 on 8.8.x 
    Issue #3041727 by Manuel Garcia, claudiu.cristea, amateescu: Convert...

  • alexpott committed 271932a on 8.7.x 
    Issue #3041727 by Manuel Garcia, claudiu.cristea, amateescu: Convert...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 8.8.x-dev » 8.7.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.