Problem/Motivation

Drupal\Tests\taxonomy\Functional\TermEntityReferenceTest doesn't do any requests, it only calls API functions, so it should be a kernel test.

Proposed resolution

Convert it.

Remaining tasks

Review.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

Release notes snippet

Nope.

CommentFileSizeAuthor
#6 3039378-6.patch2.58 KBManuel Garcia
#6 interdiff-3039378-2-6.txt734 bytesManuel Garcia
#2 3039378.patch2.53 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu created an issue. See original summary.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Active » Needs review
FileSize
3039378.patch2.53 KB

This should do it.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Looks like a good cleanup. hopefully, testbot comes back green.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Issue tags: +functional2kernel 
+++ b/core/modules/taxonomy/tests/src/Kernel/TermEntityReferenceTest.php
@@ -1,23 +1,37 @@
+  public static $modules = ['entity_test', 'field', 'system', 'taxonomy', 'text', 'user'];

This, probably, should be e multiline array.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Parent issue: » #3041700: [META] Convert some tests into Kernel or Unit tests
Manuel Garcia’s picture

Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation commented
Status: Reviewed & tested by the community » Needs review
FileSize
interdiff-3039378-2-6.txt734 bytes
3039378-6.patch2.58 KB

LGTM too, cleaned it up while I was at it (re #4).

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon commented
Status: Needs review » Reviewed & tested by the community

Perfect!

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Committed bbc3495 and pushed to 8.8.x. Thanks!

C/p as b068f166bc and pushed to 8.7.x

  • larowlan committed bbc3495 on 8.8.x 
    Issue #3039378 by Manuel Garcia, amateescu: Convert...

  • larowlan committed b068f16 on 8.7.x 
    Issue #3039378 by Manuel Garcia, amateescu: Convert...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.