Problem/Motivation

The text for the empty behavior option "text" is not translatable

Proposed resolution

Make it translatable.

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 3039172-2.patch454 bytescasey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

casey created an issue. See original summary.

casey’s picture

casey CreditAttribution: casey at SWIS commented
Status: Active » Needs review
FileSize
3039172-2.patch454 bytes
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Calibrate commented
Status: Needs review » Needs work

Instead of text, we should probably use label, that is also translatable but it is more appropriate.

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
CreditAttribution: flocondetoile at Flocon de toile commented

Are you sure of using 'label' instead of 'text' ? If we use 'label', then in the config translation UI we will get a simple textfield to translate the empty text. Where as using 'text' we will get a textarea in the config translation UI, I believe. For consistency, as the input field for empty text is a textarea we should use the 'text" property no ?

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
CreditAttribution: flocondetoile at Flocon de toile commented
Status: Needs work » Needs review

For #4

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Calibrate commented
Status: Needs review » Reviewed & tested by the community

You are right, makes more sense.

  • borisson_ committed a924b01 on 8.x-1.x authored by casey 
    Issue #3039172 by casey: Empty behavior text not translatable
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Calibrate commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.