Problem/Motivation
It is not possible to filter the inline blocks available for placement by the section to which a block is being added.
#2973615: Add Section delta as extra data on filtered block definitions added the section delta as $extra data on filtered block definitions for non-inline blocks. However, that patch failed to analogously add the section delta for inline blocks. The intent of #2973615 clearly was to affect all blocks (not just non-inline blocks), but that was not the end result so I categorized this as a bug report.
Proposed resolution
Add the delta for inline blocks too.
Remaining tasks
Add tests
Review patch.
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#19 | Screenshot from 2021-11-09 10-37-54.png | 154.27 KB | vikashsoni |
#15 | Screenshot from 2021-06-08 12-12-49.png | 134.81 KB | Rinku Jacob 13 |
#13 | 3038981-13.patch | 814 bytes | KapilV |
#11 | 3038981-3038981-inline-blocks-missing.patch | 996 bytes | dpi |
#2 | drupal-inline-blocks-delta-3038981-1.patch | 1002 bytes | jdleonard |
Issue fork drupal-3038981
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
jdleonardComment #3
jdleonardDoes this need to be fixed in 8.8 before 8.7?
Comment #4
jdleonardComment #5
tim.plunkettThanks for the patch!
This will need automated tests.
And yes, it will have to land in 8.8 first
Comment #6
tim.plunkettComment #11
dpiRerolling for D9
Comment #12
tim.plunkettThis cast isn't needed anymore since the method now specifies
int
as a typeComment #13
KapilV CreditAttribution: KapilV as a volunteer and at Innoraft for Drupal Care, Drupal Association commentedAddress #12.
Comment #14
kim.pepperComment #15
Rinku Jacob 13 CreditAttribution: Rinku Jacob 13 at Zyxware Technologies commentedpatch #11 successfully applied for drupal 9.3.x dev
Comment #17
dpiCreated MR from previous patches, reroll (merge) to 9.3.x
Comment #19
vikashsoni CreditAttribution: vikashsoni as a volunteer and at Zyxware Technologies commented@dpi and @jdleonard Patch not applying in drupal-9.3.x-dev
Comment #20
dpi@vikashsoni I've checked that the patch generated from the MR applies to HEAD of both 9.3 (drupal/core#871c1b7) and 9.4 (drupal/core#1ae88e0) cleanly as of this writing.
Don't use the patch files from this issue, per your screenshot.
Check the doc for how to use patches from MR's.
Comment #24
smustgrave CreditAttribution: smustgrave at Mobomo commentedThis issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.
For the the tests requested in #5