Fix tests following a change in Drupal 8.7.0: #2976035

Let's try this.

Ignore last patch. Interdiff is from #10.

Why uninstall + install and not just update? Is that not working?

I had the same question. I think it was not fieldable before and after this change, it is but let me try that. Install is the copy of contact_storage_test_install from core.

As I suspected in private chat with @andypost

it is because of

// If shared table schema changes are needed, we can't proceed.
    if (!class_exists($original->getStorageClass()) || $this->hasSharedTableStructureChange($entity_type, $original)) {
      throw new EntityStorageException('It is not possible to change the entity type schema outside of a batch context. Use EntityDefinitionUpdateManagerInterface::updateFieldableEntityType() instead.');
    }

in \Drupal\Core\Entity\Sql\SqlContentEntityStorageSchema::onEntityTypeUpdate()

That's pretty weird though, because in this case, we change from null storage to having a storage, but I guess that's not possible to detect unless it that storage class is hardcoded there..

Let's try this.

That's pretty weird though, because in this case, we change from null storage to having a storage, but I guess that's not possible to detect unless it that storage class is hardcoded there..

Yup, that's the problem :)

However, why do we need this test to install the contact_storage_test module from core, when #17 passed all tests?

I have no idea, I think that was an accidental copy & paste, that line has been part of the very first commit of that test, which one students worked on, and I'm sure it was started based on a copy of the core test.

Let's just commit #17, this is fine.

thanks folks

In my cursory manual testing (as part of Lightning development, since this module is used by Lightning Core), I discovered that this module cannot be installed on Drupal 8.7 without this fix. Any chance of a new release being rolled?

A release is really needed. Using this as part of lightning and tried to add the patch in #17 or #25 to my composer.json and just get

[ErrorException]
Array to string conversion

when running composer install (error is from composer-patches). Other patches (like in drupal/core) work so not sure what composer's problem is with this. But being able to just update the module version instead of patching would be much nicer.

That error typically happens if the same patch is included twice, it is possible that lightning itself already includes it?