1) Drupal\Tests\commerce_product\Kernel\ProductVariationAccessTest::testRouteAccess
TypeError: Argument 1 passed to Drupal\Core\Plugin\Context\EntityContext::fromEntity() must implement interface Drupal\Core\Entity\EntityInterface, null given, called in /var/www/html/core/modules/user/src/ContextProvider/CurrentUserContext.php on line 58

/var/www/html/core/lib/Drupal/Core/Plugin/Context/EntityContext.php:56
/var/www/html/core/modules/user/src/ContextProvider/CurrentUserContext.php:58
/var/www/html/core/modules/user/src/ContextProvider/CurrentUserContext.php:74
/var/www/html/core/lib/Drupal/Core/Plugin/Context/LazyContextRepository.php:97
/var/www/html/core/lib/Drupal/Core/ParamConverter/EntityConverter.php:137
/var/www/html/core/lib/Drupal/Core/ParamConverter/ParamConverterManager.php:100
/var/www/html/core/lib/Drupal/Core/Access/AccessManager.php:89
/var/www/html/core/lib/Drupal/Core/Url.php:809
/var/www/html/modules/contrib/commerce/modules/product/tests/src/Kernel/ProductVariationAccessTest.php:186
CommentFileSizeAuthor
#16 commerce-3038493-test_failures-16.patch541 bytesczigor
#9 interdiff-9.txt2.49 KBamateescu
#9 3038493-9.patch10.71 KBamateescu
#8 3038493.patch8.22 KBamateescu
#3 3038493-3.patch1.65 KBflocondetoile
#2 3038493-2.patch2.02 KBflocondetoile
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
CreditAttribution: flocondetoile at Flocon de toile commented
Status: Active » Needs review
FileSize
3038493-2.patch2.02 KB

Same fix than #3038391: Fix failing ProfileAccessTest::testProfileCreateAccess on 8.7.x

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
CreditAttribution: flocondetoile at Flocon de toile commented
FileSize
3038493-3.patch1.65 KB

Sorry #2 has trailing diff of an another work

Status: Needs review » Needs work

The last submitted patch, 3: 3038493-3.patch, failed testing. View results

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
CreditAttribution: flocondetoile at Flocon de toile commented

Oh. There's a lot more testing to fix than I thought :-( Or the fix is completely wrong ?

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

Core has introduced more breakage, via #2976035: Entity type CRUD operations must use the last installed entity type and field storage definitions .

1) Drupal\Tests\commerce_cart\Kernel\OrderItemMatcherTest::testOrderItemMatcher
Argument 1 passed to Drupal\Core\Entity\Sql\SqlContentEntityStorageSchema::getTableMapping() must implement interface Drupal\Core\Entity\EntityTypeInterface, null given, called in /var/www/html/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorageSchema.php on line 1477 and defined

/var/www/html/vendor/symfony/phpunit-bridge/DeprecationErrorHandler.php:290
/var/www/html/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorageSchema.php:193
/var/www/html/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorageSchema.php:1477
/var/www/html/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorageSchema.php:621
/var/www/html/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php:1540
/var/www/html/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php:1593
/var/www/html/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php:1541
/var/www/html/core/lib/Drupal/Core/Field/FieldStorageDefinitionListener.php:87
/var/www/html/core/modules/field/src/Entity/FieldStorageConfig.php:340
/var/www/html/core/modules/field/src/Entity/FieldStorageConfig.php:294
/var/www/html/core/lib/Drupal/Core/Entity/EntityStorageBase.php:490
/var/www/html/core/lib/Drupal/Core/Entity/EntityStorageBase.php:445
/var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:263
/var/www/html/core/lib/Drupal/Core/Entity/EntityBase.php:394
/var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:613
/var/www/html/core/lib/Drupal/Core/Config/ConfigInstaller.php:343
/var/www/html/core/lib/Drupal/Core/Config/ConfigInstaller.php:132
/var/www/html/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
/var/www/html/core/tests/Drupal/KernelTests/KernelTestBase.php:692
/var/www/html/modules/contrib/commerce/modules/cart/tests/src/Kernel/OrderItemMatcherTest.php:64

1) Drupal\Tests\commerce_cart\Kernel\CartQueryAccessTest::testAccess
Drupal\Core\Entity\EntityStorageException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'cart' in 'field list': INSERT INTO {commerce_order} (type, uuid, order_number, store_id, uid, mail, ip_address, billing_profile__target_id, billing_profile__target_revision_id, total_price__number, total_price__currency_code, total_paid__number, total_paid__currency_code, state, data, locked,
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Title: ProductVariationAccessTest is failing on Drupal 8.7 » Tests are failing on Drupal 8.7

https://www.drupal.org/node/3036689 might be a clue.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs work » Needs review
FileSize
3038493.patch8.22 KB

This should fix everything.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
FileSize
3038493-9.patch10.71 KB
interdiff-9.txt2.49 KB

Ok, almost everything :)

Not sure what's up with \Drupal\Tests\commerce_log\Kernel\OrderIntegrationTest, it's not related to the stuff I worked on for 8.7.

The last submitted patch, 8: 3038493.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 9: 3038493-9.patch, failed testing. View results

drugan’s picture

drugan CreditAttribution: drugan as a volunteer commented
Status: Needs work » Needs review

I am not sure if this somehow related to the test fail but who knows:

https://cgit.drupalcode.org/drupal/tree/core/tests/Drupal/KernelTests/Ke...

https://cgit.drupalcode.org/drupal/tree/core/includes/bootstrap.inc?h=8....

drugan’s picture

drugan CreditAttribution: drugan as a volunteer commented
Status: Needs review » Needs work

  • bojanz committed b751885 on 8.x-2.x authored by amateescu 
    Issue #3038493 by amateescu, flocondetoile: Tests are failing on Drupal...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

Thanks flocondetoile and amateescu!
I've committed #9 since it fixes the majority of test fails.

Andras and myself will look into OrderIntegrationTest on monday.
It would make sense to bisect core 8.7.x commits to find which one broke OrderIntegrationTest, cause it was passing until very recently.

I do wonder if it's this one:

commit e866ce6c13a3b31bca2a4d0b65464365597ccf44
Author: Alex Pott <alex.a.pott@googlemail.com>
Date:   Fri Mar 8 10:05:33 2019 +0000

    Issue #2788637 by mglaman, Berdir, bradjones1, effulgentsia, alexpott, amateescu, borisson_: Values in shared table for SQL content entity storage do not get unserialized
    
    (cherry picked from commit 54ff737a18c75663f6988603adffe93418a3e86a)
czigor’s picture

czigor CreditAttribution: czigor at Centarro commented
Status: Needs work » Needs review
FileSize
commerce-3038493-test_failures-16.patch541 bytes

It was indeed e866ce6c13a3b31bca2a4d0b65464365597ccf44.

Before that core commit, empty serialized field values appeared as "a:0:{}" in $entity->value. This mapped to a proper MapFieldItemList in $entity->fields. Now the field in $entity->value is just empty which breaks field mapping.

Fixing this inside Log.

  • bojanz committed c5a8429 on 8.x-2.x authored by czigor 
    Issue #3038493 part II by czigor: Tests are failing on Drupal 8.7
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Thanks, Andras!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.