CommentFileSizeAuthor
#5 entity-best-practice-3037934-2.patch1.4 KBnitin.ahire
#2 entity-best-practice-3037934-1.patch3.03 KBnitin.ahire
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nitin.ahire created an issue. See original summary.

nitin.ahire’s picture

nitin.ahire CreditAttribution: nitin.ahire commented
Status: Active » Needs work
FileSize
entity-best-practice-3037934-1.patch3.03 KB
nitin.ahire’s picture

nitin.ahire CreditAttribution: nitin.ahire commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: entity-best-practice-3037934-1.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

nitin.ahire’s picture

nitin.ahire CreditAttribution: nitin.ahire commented
FileSize
entity-best-practice-3037934-2.patch1.4 KB

Updated patch.

nitin.ahire’s picture

nitin.ahire CreditAttribution: nitin.ahire commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: entity-best-practice-3037934-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

TR’s picture

TR CreditAttribution: TR commented
Status: Needs work » Needs review

Test failures are unrelated to this patch; they are because of #3039040: Tests are failing on Drupal 8.7.x

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Title: Replace t() with $this->t() as a best practices » Replace t() with $this->t() where possible

  • bojanz committed 30218db on 8.x-1.x authored by nitin.ahire 
    Issue #3037934 by nitin.ahire: Replace t() with $this->t() where...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Thanks!

nitin.ahire’s picture

nitin.ahire CreditAttribution: nitin.ahire at Invezza Technologies commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.