Currently no delta is defined for the weight in buildTampersTable() so when you read 20, all tampers get the same delta which can lead to incorrect tampers order.

CommentFileSizeAuthor
#5 feeds_tamper-weight-delta-3037869-5.patch4 KBMegaChriz
#4 feeds_tamper-weight_delta-3037869-4.patch953 bytestostinni
#2 feeds_tamper-weight_delta-3037869-2.patch936 bytestostinni
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tostinni created an issue. See original summary.

tostinni’s picture

tostinni CreditAttribution: tostinni at Agence Propal commented
Status: Active » Needs review
FileSize
feeds_tamper-weight_delta-3037869-2.patch936 bytes

Inspired by #2939634: Unable to order transitions if there are more than 20, I added a dynamic delta for the weight so it can always keep up with the number of tampers.

Status: Needs review » Needs work

The last submitted patch, 2: feeds_tamper-weight_delta-3037869-2.patch, failed testing. View results

tostinni’s picture

tostinni CreditAttribution: tostinni at Agence Propal commented
Status: Needs work » Needs review
FileSize
feeds_tamper-weight_delta-3037869-4.patch953 bytes

Adding a minimum value so the test doesn't fail.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
FileSize
feeds_tamper-weight-delta-3037869-5.patch4 KB

Nice patch. Here is one with an automated test.

  • MegaChriz committed 3f4981d on 8.x-2.x authored by tostinni 
    Issue #3037869 by tostinni, MegaChriz: Fixed unable to order tampers if...
MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
Status: Needs review » Fixed

Committed #5 with some extra comments on TamperListForm.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.