Problem/Motivation

From #3037668-2: Improve visual coherence of the media library:

The "Image" tab top white margin/padding seems to be smaller than the bottom padding, also possibly true for the gray tabs, even those that don't have drop shadows dropping on them.

Proposed resolution

Make sure the top and bottom paddings on the vertical tabs are consistent.

Remaining tasks

Write patch
Review
Commit

User interface changes

Change the padding on the media library vertical tabs.

Before:
Vertical tabs padding before.

After:
Vertical tabs padding after.

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 vertical-tabs-padding-after.png657.37 KBseanB
#2 vertical-tabs-padding-before.png656.49 KBseanB
#2 3037766-2.patch509 bytesseanB
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

seanB created an issue. See original summary.

seanB’s picture

seanB
Primary language Dutch
Location Netherlands
CreditAttribution: seanB commented
Issue summary: View changes
FileSize
3037766-2.patch509 bytes
vertical-tabs-padding-before.png656.49 KB
vertical-tabs-padding-after.png657.37 KB

Attached is a patch to fix it. Also added screenshots to the IS.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Reviewed & tested by the community

Looks good to me.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Looks so much better!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed :)

Ps. credited myself based on discussions in #3037668: Improve visual coherence of the media library.

  • Gábor Hojtsy committed 86926a8 on 8.7.x 
    Issue #3037766 by seanB, phenaproxima, Gábor Hojtsy: Inconsistent margin...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.