The system save message and module save message duplicate information. See attached image.

It might be considered to either suppress the system message or concatenate additional information from module to system save message.

CommentFileSizeAuthor
#7 3037094-7.patch1.3 KBneslee canil pinto
#5 double_message_upon_save-3037094-5.patch1.52 KBgrace_kezia
#2 double_message_upon_save-3037094-2.patch1.52 KBsergiu stici
Screen Shot 2019-03-02 at 7.53.54 PM.jpg23.84 KBtomsherlock

Comments

TomSherlock created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
StatusFileSize
new double_message_upon_save-3037094-2.patch1.52 KB

I fixed the issue, and replaced deprecated functions drupal_get_message() and drupal_set_message() with Drupal Messenger service.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
wturrell’s picture

wturrell commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

This patch doesn't seem to apply cleanly to 1.0.0-rc1 (either using composer or manually with git apply -v)
From a brief visual comparison of the source code I'm not clear why…

grace_kezia’s picture

grace_kezia commented
Version: 8.x-1.0-rc1 » 8.x-1.x-dev
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new double_message_upon_save-3037094-5.patch1.52 KB

Uploading re roll patch for dev version.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Needs work 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1558  100  1558    0     0    974      0  0:00:01  0:00:01 --:--:--   974
warning: addanother.module has type 100755, expected 100644
error: patch failed: addanother.module:133
error: addanother.module: patch does not apply
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3037094-7.patch1.3 KB

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.