Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Part of effort: #1577902: [META] Remove all usages of drupal_static() & drupal_static_reset()
Remove drupal_static()
from install_profile_info()
.
Proposed resolution
install_profile_info()
is procedural code and I don't see any reason why it's internal cache should be resettable from outside. Using the static
statement sound legit here.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
N/A
Comment | File | Size | Author |
---|---|---|---|
#2 | 3036962-2.patch | 472 bytes | claudiu.cristea |
Comments
Comment #2
claudiu.cristeaPatch.
Comment #3
andypostLooks there's no static reset for this var, so looks good to go
Comment #5
andypostComment #6
catchIs there an issue to move this functionality to the extension system? I think this is fine in order to kill off drupal_static() but it'd be good to kill off this function too.
Comment #7
andypost@catch guess #2721603: ExtensionList cleanup and separation of concerns
Comment #9
catchThanks @andypost, that led me to #2024043: Add Module, Theme, Profile, and Extension value objects which might be the one.
Comment #10
larowlanCommitted 96649b0 and pushed to 8.8.x. Thanks!
Comment #11
claudiu.cristeaLooks like the commit is missed from the repo
Comment #13
larowlanwhoops