I've created a module called Facets Range Input. Code is mostly inspired by the range slider sub-module. Currently, it requires the attached patch to work properly.

Module page for range input: https://www.drupal.org/project/facets_range_input

Is there a way to plug into the js api for modules like this?

CommentFileSizeAuthor
#12 3034918-12.patch504 bytesdench0
#4 add-range-input-view-update-3034918.patch595 bytesalexandersluiter
#3 add-range-input-view-update-3034918.patch595 bytesalexandersluiter
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexandersluiter created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Issue tags: +Novice

This looks really cool!

A novice could upload a patch here to add this project to the readme.txt, similar to what happened over in #3006950.

alexandersluiter’s picture

alexandersluiter CreditAttribution: alexandersluiter commented
FileSize
add-range-input-view-update-3034918.patch595 bytes

No need for any of the other patches now that the Javascript API is coming together. This small patch is all that's needed in order to tell the JS API to skip updating the range input form blocks.

alexandersluiter’s picture

alexandersluiter CreditAttribution: alexandersluiter commented
Issue summary: View changes
Related issues: -#2986981: Ajax facet block seems to lose Views context (filters, etc), -#3013795: Robustify how ajax finds the facet block, -#3012531: Ajax Facets do not support Range Slider
FileSize
add-range-input-view-update-3034918.patch595 bytes
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented

Ok so that means we're probably should commit this small change. I will create a new issue for the readme.txt update.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Active » Needs review

Go testbot, go!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented

The readme update can go in #3054542: Add documentation about the facets_range_input module

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin at Geeks4Change, MachbarMacher commented
Parent issue: » #3075378: [META] Overview of Facets + Ajax issues
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Tag1 Consulting commented

Bump

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Needs review » Fixed

@heddn: Was that a reminder to commit this, or something else? Setting to rtbc is a more effective indicator of that.

In any case, I totally forgot about this issue. I committed #4.

dench0’s picture

dench0 CreditAttribution: dench0 commented
Status: Fixed » Needs review
FileSize
3034918-12.patch504 bytes

The last commit can break view ajax executing if drupalSettings.facets is undefined.
For example, on page exist only List of links widget with soft_limit = 0. In this case drupalSettings.facets is absent and this checking will trow a TypeErrorwith message "settings.facets is undefined".

  • borisson_ committed be2b9dd on 8.x-1.x authored by dench0 
    Issue #3034918 by alexandersluiter, dench0, borisson_: Followup - Add...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Calibrate commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.