Problem/Motivation

Deprecated strtolower need to be replaced with Drupal Services
in Drupal 8.6.0, will be removed before Drupal 9.0.0.

Proposed resolution

Use mb_strtolower() instead. According tohttps://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Utility%21Unicode.php/function/Unicode%3A%3Astrtolower/8.6.x

Remaining tasks

Update the deprecated method and provide the patch

CommentFileSizeAuthor
#5 Deprecated_strtolower_removed-3034169-5.patch1.98 KBakshay_d
#2 Deprecated_strtolower_removed-3034169-2.patch3.98 KBakshay_d
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akshay_d created an issue. See original summary.

akshay_d’s picture

akshay_d
Primary language Kannada
Location Bangalore
CreditAttribution: akshay_d at Specbee commented
Status: Active » Needs review
FileSize
Deprecated_strtolower_removed-3034169-2.patch3.98 KB

removed deprecated method

Status: Needs review » Needs work

The last submitted patch, 2: Deprecated_strtolower_removed-3034169-2.patch, failed testing. View results

akshay_d’s picture

akshay_d
Primary language Kannada
Location Bangalore
CreditAttribution: akshay_d at Specbee commented
Component: Documentation » xmlsitemap.module
akshay_d’s picture

akshay_d
Primary language Kannada
Location Bangalore
CreditAttribution: akshay_d at Specbee commented
Status: Needs work » Needs review
FileSize
Deprecated_strtolower_removed-3034169-5.patch1.98 KB

updated the patch please review

SabitDev’s picture

SabitDev CreditAttribution: SabitDev at EPAM Systems, Drupal Ukraine Community commented
Status: Needs review » Reviewed & tested by the community

Tested and reviewed, everything works correctly

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at EPAM Systems, Drupal Ukraine Community for EPAM Systems, Drupal Ukraine Community commented

  • pifagor committed 3d545fb on 8.x-1.x 
    Issue #3034169 by akshay_d, SabitDev, pifagor: Deprecated strtolower...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at EPAM Systems, Drupal Ukraine Community for EPAM Systems, Drupal Ukraine Community commented
Status: Reviewed & tested by the community » Fixed

I rerolled the patch

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at Drupal Ukraine Community, GOLEMS GABB for Drupal Ukraine Community, GOLEMS GABB commented

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Dave Reid credited thalles.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented