Problem/Motivation

In #3025657-50: Add views area plugin to display a link to another view display within the same view the display link plugin was added and the suggestion was made to use '#theme' => 'link__views_display_link' to allow the display links to be themed.

While working on #2981044: Unify the grid/table views of the media library, I noticed the log contains a lot of Theme hook link not found. errors, caused by the fact link__views_display_link builds on a non-existing hook_link.

Proposed resolution

Since hook link was removed on purpose (https://www.drupal.org/node/2061877), and you can already use hook_link_alter to change the link, let's just remove '#theme' => 'link__views_display_link' to fix the issue for now.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3033404-2-PASS.patch2.3 KBphenaproxima
#2 3033404-2-FAIL.patch1.42 KBphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

seanB created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Title: Views DisplayLink plugins uses non-existing hook_link. » Views DisplayLink area plugin tries to use non-existent theme hook
Status: Active » Needs review
FileSize
3033404-2-FAIL.patch1.42 KB
3033404-2-PASS.patch2.3 KB

OK, here is the fix with a test.

The last submitted patch, 2: 3033404-2-FAIL.patch, failed testing. View results

seanB’s picture

seanB
Primary language Dutch
Location Netherlands
CreditAttribution: seanB at Acquia commented
Status: Needs review » Reviewed & tested by the community

Yay! Looks good to me.

  • xjm committed c1f7ffa on 8.7.x 
    Issue #3033404 by phenaproxima, seanB: Views DisplayLink area plugin...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.7.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.