Problem/Motivation

Constant REQUEST_TIME is deprecated. See: https://www.drupal.org/node/2785211
File:

  • backup_migrate/src/Entity/Schedule.php
  • backup_migrate/src/Controller/ScheduleListBuilder.php

Proposed resolution

Use \Drupal::time()->getRequestTime();

Remaining tasks

  1. Create patch
  2. Needs Review

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 backup_migrate-replaced_request_time-3028984-2.patch2.63 KBi-trokhanenko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

i-trokhanenko created an issue. See original summary.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
CreditAttribution: i-trokhanenko at RockSolid PSF commented
Assigned: i-trokhanenko » Unassigned
Issue summary: View changes
Status: Active » Needs review
FileSize
backup_migrate-replaced_request_time-3028984-2.patch2.63 KB

Please review.

Roman Dyn’s picture

Roman Dyn CreditAttribution: Roman Dyn as a volunteer and at RockSolid PSF commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Applied patch #2. It works well! Need commit. Thanks.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed
Parent issue: » #3009642: Plan for Backup and Migrate 8.x-4.1

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.