Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The default value of the "$secure" and "$samesite" arguments of "Symfony\Component\HttpFoundation\Cookie::__construct"'s constructor will respectively change from "false" to "null" and from "null" to "lax" in Symfony 5.0, you should define their values explicitly or use "Cookie::create()" instead.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3027910.patch | 1.81 KB | catch |
| #3 | 3027910-combined.patch | 159.41 KB | catch |
Comments
Comment #2
BerdirNote from slack discussion:
This is a symfony 4 deprecation, we might not be able to do anything about that if we want to remain compatible with Symfony 3 but would have to add that to the excluded deprecation message list instead.
Comment #3
catchWe can and we can't do something about this.
Symfony is using the deprecation to ensure everyone specifies the default values, this is in preparation for changing the defaults in Symfony 5.
I found two places in core where we can just explicitly set the default values, so that's fine.
But Behat\Mink\Driver\BrowserKitDriver also uses the same class with the same problem, so it'll need an upstream fix and/or us adding it to skipped deprecations until an upstream fix is available. Did not look at the latter problem yet but here's a quick patch for our code.
Comment #4
catchNo mink update yet that I could find, so I posted a PR: https://github.com/minkphp/MinkBrowserKitDriver/pull/130
Comment #6
catchWe don't seem to be getting hit by the Mink usage (unless I'm missing something in the test results) so #3 might be enough.
Comment #7
alexpottThis looks fine for now and if the mink usage becomes an issue we can follow-up in yet-another issue.
Comment #8
larowlanCommitted ffad365 and pushed to 8.7.x. Thanks!