Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
From https://www.drupal.org/project/drupal/issues/2976394#comment-12938274
Drupal\Tests\field\Functional\Hal\FieldConfigHalJsonCookieTest::testGet
Exception: TypeError: Argument 1 passed to Symfony\Component\HttpFoundation\Response::setCharset() must be of the type string, null given, called in /var/www/html/core/modules/rest/src/EventSubscriber/ResourceResponseSubscriber.php on line 210
Symfony\Component\HttpFoundation\Response->setCharset()() (Line: 496)
Drupal\Tests\action\Functional\ActionListTest::testEmptyActionList
Exception: TypeError: Argument 1 passed to Symfony\Component\HttpFoundation\Response::setCharset() must be of the type string, null given, called in /var/www/html/core/lib/Drupal/Component/HttpFoundation/SecuredRedirectResponse.php on line 43
Symfony\Component\HttpFoundation\Response->setCharset()() (Line: 496)
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#4 | interdiff.txt | 1002 bytes | Gábor Hojtsy |
#4 | 3027835-4.patch | 1.83 KB | Gábor Hojtsy |
#4 | 3027835-4-combined.patch | 157.6 KB | Gábor Hojtsy |
#2 | 3027835.patch | 871 bytes | catch |
#2 | 3027835-combined.patch | 156.63 KB | catch |
Comments
Comment #2
catchThis might be all we need to do.
Comment #3
Gábor HojtsyThere is also the same fail in ResourceResponseSubscriber.php as in the paste :) There does not seem to be other affected code. Full output:
Comment #4
Gábor HojtsyThere you go.
Comment #7
catchPatch up at #3027872: [symfony 4] The default value of the "$secure" and "$samesite" arguments of "Symfony\Component\HttpFoundation\Cookie::__construct"'s constructor will change.
Comment #8
alexpottLooks good to me. Can't see any downsides.
Comment #9
larowlanCommitted db42557 and pushed to 8.7.x. Thanks!