Migrate D7 comment type language settings

I tested path #4 manually.

1. Content type with multilingual settings 'disabled': All three language settings are according to the IS.

2. Content type with multilingual settings 'enabled': All three language settings are according to the IS.

3. Content type with multilingual settings 'enabled, with translation': All three language settings are according to the IS.

4. Content type with multilingual settings 'enabled, with field translation' i.e. Entity Translation

• 'Default language' was migrated correctly as 'Interface text language selected for page'
• 'Show language selector' was migrated correctly as enabled.
• The expected result for 'Enable translation' depends on the Entity Translation settings defined in D7 at admin/config/regional/entity_translation
  • I first tested this so that Comments was not defined as translatable entity type. This test FAILED, the 'Enable translation' was migrated as 'enabled'.
  • I then re-tested this so that Comments was defined as translatable entity type. The 'Enable translation' was migrated as 'enabled' as expected.
  • I also updated the IS to be more explicit on this.

5. Other review comments for the patch.

+++ b/core/modules/language/tests/src/Kernel/Migrate/d7/MigrateLanguageContentCommentSettingsTest.php
+  /**
+   * Tests migration of content language settings.
+   */
+  public function testLanguageCommentSettings() {

Should be 'Tests migration of comment language settings.'

6. When testing this issue, I got the following migration error:

• 'Operation on Custom block translations failed'
• 'Migration failed with source plugin exception: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'your-db-name.i18n_string' doesn't exist: SELECT b.bid AS bid, b.format AS format, b.body AS body, i18n.property AS property, lt.lid AS lid, lt.translation AS translation, lt.language AS language, b.info AS title FROM @block_custom b LEFT OUTER JOIN @i18n_string i18n ON i18n.objectid = CAST(b.bid as CHAR(255)) LEFT OUTER JOIN @locales_target lt ON lt.lid = i18n.lid WHERE (lt.lid IS NOT NULL) AND (i18n.type = :db_condition_placeholder_0) ORDER BY b.bid ASC; Array ( [:db_condition_placeholder_0] => block )'

I re-ran my D7 migration also without the latest patch applied (i.e. current 8.7.x) and as I expected, this error was not caused by this patch. Does this ring a bell to anyone and do we already have an issue opened to address this error?

Cheers,
Markus

Almost there.

1. +++ b/core/modules/content_translation/migrations/d7_language_content_comment_settings.yml
   @@ -0,0 +1,63 @@
   +# Ignore i18n_node_options_[node_type] options not available in Drupal 8,
   +# i18n_required_node and i18n_newnode_current
   

   I commented in another issue about this. This should be removed. I think.

2. +++ b/core/modules/language/tests/src/Kernel/Migrate/d7/MigrateLanguageContentCommentSettingsNoEntityTranslationTest.php
   @@ -0,0 +1,116 @@
   +   * Tests migration of content language settings.
   

   Still needs addressed from earlier (#5.5).

Thanks for working on this. This looks good to me other than naming things :D

+++ b/core/modules/content_translation/migrations/d7_language_content_comment_settings.yml
@@ -0,0 +1,61 @@
+id: d7_language_content_comment_settings
+label: Drupal 7 language content comment settings

+++ b/core/modules/language/tests/src/Kernel/Migrate/d7/MigrateLanguageContentCommentSettingsTest.php
@@ -0,0 +1,98 @@
+ * Tests migration of language comment settings.

These are about "Drupal 7 comment language settings" no? Language of comments. "Content" is superfluous as you can only comment on content.

Same for the ID, it would be "d7_comment_language_settings" or somesuch no? Or does that need to follow naming pattern of d7_language_...? (If so, then keep the ID as is IMHO).

Hm I see these naming schemes are just consistent with the previously created #2981393: Migrate D6 comment type language settings so this should be fine as-is.

Committed and pushed f3216900b1 to 8.8.x and 17c9135b8e to 8.7.x. Thanks!