Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is comment and taxonomy test, no change at all just copy paste. More granular tests let you pick which to run, when running all you can make them more parallel, slower machines do not time out...
Comment | File | Size | Author |
---|---|---|---|
#9 | unappaproved.patch | 1.48 KB | catch |
#7 | testslices_0.patch | 18.17 KB | catch |
#6 | testslices.patch | 18.17 KB | chx |
testslices.patch | 18.17 KB | chx | |
Comments
Comment #1
chx CreditAttribution: chx commentedComment #2
catchNo time to test now but just a quick note that in #296009: TestingParty08: Comment signatures I moved postComment out to drupal_web_test_case and made the signature test it's own class. I agree with this in general, not sure myself where postComment should live, but worth mentioning.
Comment #3
Damien Tournoud CreditAttribution: Damien Tournoud commentedI would love to see postComment being part of CommentHelperCase and the Comment signature test be a subclass of that. That would be awesome.
Comment #4
Robin Monks CreditAttribution: Robin Monks commentedIt seems like a solid patch, and the tests (comment and taxonomy) ran fine, "533 passes, 0 fails, 0 exceptions". Looks good to me. Not sure what will happen with #2 and #3, but, the patch does work.
Robin
Comment #5
Dries CreditAttribution: Dries commentedThe description of CommentAnonymous is not valid. Other descriptions might need double-checking too.
Comment #6
chx CreditAttribution: chx commentedFixed the descriptions , and read all of them.
Comment #7
catchFixed a spelling error which was in the original test but not caught by the split. Read through everything and it seems reasonable. There's a lot more cleanup of comment.test could be done - but we can do that in other patches.
Comment #8
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #9
catchNow it's my turn to break tests :(
Call to undefined method CommentApprovalTest::getUnaprovedComment().
Sorry.
Comment #10
Damien Tournoud CreditAttribution: Damien Tournoud commentedGood lord :)
Comment #11
webchickHehe. Committed. ;)
Comment #12
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.