Problem/Motivation

The automated tests are failing, see https://www.drupal.org/node/632214/qa

Proposed resolution

  1. Fix the schema errors reported in Drupal\Tests\colorbox\FunctionalJavascript\ColorboxJavascriptTest
  2. NodeCreationTrait was moved from namespace Drupal\simpletest to Drupal\Tests\node\Traits.
    reference in \Drupal\Tests\colorbox\FunctionalJavascript\ColorboxJavascriptTest should be updated.

    see https://www.drupal.org/node/2884454

  3. Switch to \Drupal\FunctionalJavascriptTests\WebDriverTestBase, since JavaScriptTestBase is deprecated.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#4 colorbox-fix_automated_test-3023262-4.patch3.03 KBidebr
#4 interdiff-3-4.txt2.52 KBidebr
#3 colorbox-3023262-3.patch712 bytesoknate
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

oknate created an issue. See original summary.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
FileSize
colorbox-3023262-3.patch712 bytes
idebr’s picture

idebr CreditAttribution: idebr at iO commented
Title: Update NodeCreationTrait namespace » ColorboxJavascriptTest is failing
Issue summary: View changes
Status: Active » Needs review
FileSize
interdiff-3-4.txt2.52 KB
colorbox-fix_automated_test-3023262-4.patch3.03 KB

Attached patch fixes the ColorboxJavascriptTest by fixing the schema errors. It also updates traits and its base class to non-deprecated versions.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Looks good to me, marking RTBC.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented

Much needed patch. Thanks

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Reviewed & tested by the community » Needs work

@idebr and @oknate #4 didn't solve that issue yet. https://www.drupal.org/node/632214/qa is still failing for 8.x-1.x.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs work » Fixed

Thanks, Tests got pass.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.