Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Some coding standards are not applied.
This can be checked online using:
https://pareview.sh/pareview/https-git.drupal.org-project-workflow.git
| Comment | File | Size | Author |
|---|---|---|---|
| #19 | workflow-3022421-19-codingstandards.patch | 62.93 KB | johnv |
| #14 | Drupal_Coding_Standard_Fixing-3022421-14.patch | 0 bytes | vipul tulse |
| #13 | workflow module file remaining issue.txt | 4.8 KB | vipul tulse |
| #7 | Drupal_Coding_Standard_Fixing-3022421-7.patch | 22.16 KB | vipul tulse |
| #6 | workflow.module-file issue.txt | 11.68 KB | vipul tulse |
Comments
Comment #2
vipul tulse CreditAttribution: vipul tulse commentedCoding standard issue For d8 version:
Comment #3
vipul tulse CreditAttribution: vipul tulse commentedWorking on the coding standard fixing, will attach the issue txt file soon
Comment #4
vipul tulse CreditAttribution: vipul tulse commentedHello @johnv,
Is there any way that I can review and commit the changes file by file because don't want to add too many patches.
Please guide me.
Comment #5
johnvComment #6
vipul tulse CreditAttribution: vipul tulse commentedCurrently working on fixing this coding standard issues using phpcs/phpcbf with Drupal coder with coding standard "Drupal" and "DrupalPractice".
Attached files is the list of issues found in workflow.module file
Comment #7
vipul tulse CreditAttribution: vipul tulse commentedHello @johnv
Attached patch contains bugs resolved for Drupal, DrupalPractice.
phpcbf --standard=Drupal workflow.module
phpcbf --standard=DrupalPractice workflow.module
Remaining Bugs list is, need your help to remove the @params from hook comment
FILE: /var/www/html/drupalcontrib/modules/contrib/workflow/workflow.module
---------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 12 WARNINGS AFFECTING 18 LINES
---------------------------------------------------------------------------------------------------------------------
45 | WARNING | Hook implementations should not duplicate @param documentation
48 | WARNING | Hook implementations should not duplicate @return documentation
86 | WARNING | Hook implementations should not duplicate @param documentation
88 | WARNING | Hook implementations should not duplicate @param documentation
90 | WARNING | Hook implementations should not duplicate @param documentation
102 | WARNING | Hook implementations should not duplicate @param documentation
117 | WARNING | Hook implementations should not duplicate @param documentation
127 | WARNING | Hook implementations should not duplicate @param documentation
139 | WARNING | Hook implementations should not duplicate @param documentation
151 | WARNING | Line exceeds 80 characters; contains 90 characters
153 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
173 | WARNING | Hook implementations should not duplicate @param documentation
239 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
258 | WARNING | Line exceeds 80 characters; contains 86 characters
332 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
408 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
438 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
483 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
---------------------------------------------------------------------------------------------------------------------
Comment #10
johnvThanks. this file is committed.
I changed some things in comments,
And you removed some t()calls.
Comment #11
johnvComment #12
johnvCan you run the test again, to have new, actual line numbers?
Comment #13
vipul tulse CreditAttribution: vipul tulse commentedHello @johnv
Ran the test again and attached is the list of the issue still exist in the .module file
you removed some t()calls?
+ ANS : To remove below drupal coding standard issue
377 | WARNING | [ ] Only string literals should be passed to t() where possible
If removing of the t() casing any issue then it's fine to keep them otherwise good to remove
Can I proceed further to fix the remaining issue? or start working on another file.
Comment #14
vipul tulse CreditAttribution: vipul tulse commentedWorking on the .install file coding standard review, please ignore this patch.
Comment #15
johnvComment #17
johnvlots of code-sniffer changes.
Comment #19
johnvComment #22
johnvAbove patch should be enough. Have not implemented all remarks, especially no the inline comments and indenting of commented code.
Leaving this issue open for future work.
Comment #27
johnvComment #39
johnv