Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dmitrig01’s picture

To explain: The themes page already looks like this, and I'm hoping to convert more pages to this look - like the modules page (if people don't object).

nielsbom’s picture

Good call, but isn't it even better to skip the whole machine-name/system name thing and let Drupal lowercase it all, make underscores out of spaces and use numbers if there are double entries?

Why let a person do a computer's job? I don't really care how a content type is called inside Drupal, as long as it uses the regular name for me.

One less input field to read and fill out.

Dries’s picture

Looks prettier to me. Not sure the machine name is really that valuable for end-users.

BioALIEN’s picture

Any use cases where machine_name would be needed?

I doubt anybody would give identical names to 2 or more content types. However, I am against the comments in #2, definitely keep machine_name in screenshot 2. There are too many modules that depend on this. Flexibility is a good thing (tm).

maartenvg’s picture

Looks nice and +1 for consistency. With or without displaying the machine name is fine by me. If it stays, then this way of displaying it is a nice, unobtrusive method.

Concerning the slightly off-topic debate: I'm not a big proponent for automatically creating the machine readable name, because if you alter the Human readable name of the node type, you don't want to break the links to the pages that use the machine readable name.

Example.
Creating Blog item becomes blog_item.
Editing blog to Personal blog item becomes personal_blog_item. Now all references to blog_item (like node/add/blog_item) cease to exist and you have to resort to the path module to fix it.

nielsbom’s picture

#5
> I'm not a big proponent for automatically creating the machine readable name, because
True, but we can probably solve this in a good way, maybe by using an id instead of a "name", machines don't care :)

dmitrig01’s picture

#2 - I care what the name is.
#5 - that is completely off-topic.

Pasqualle’s picture

the default machine readable name should be filled in automatically with javascript (like the admin email at install), and changed manually if needed. but it is an another issue..

dmitrig01’s picture

Dries’s picture

Status: Needs review » Needs work

Let's go with the patch as is. However, it will need a quick re-roll to replace "'Machine Name" with "Machine name" and stuff. Should be trivial.

alpritt’s picture

The titles should be in header tags. The themes page uses h2 and I think that works here too.

I think we can lose the 'name' table header. It's not strictly accurate now that there are 3 items under it, and it is self explanatory anyway. Ditto with operations; IMO it's just chart junk.

I don't think that grey for the descriptions has enough contrast, but perhaps that is another issue. The machine name should probably have less contrast as it is still too prominent and difficult for non-developers to ignore. Possibly, it should be repositioned too so it is not automatically read when reading the content type titles.

Before committing, it should also be checked over in our alternate themes.

maartenvg’s picture

Patch applies, but the effect is broken. See attached screenshot

alpritt’s picture

@#12: You just need to clear the cache.

illuminaut’s picture

I don't think the machine name should be displayed in the overview, as it's only of marginal value to end users. It's fine to display the field in the edit window, and if you need to know the machine name you can look it up that way.

I also don't particularly like the term "Machine name" and would prefer "System identifier", but I'm sure this has been discussed before and someone can direct me to the appropriate thread for that one.

catch’s picture

Use cases for choosing machine name - views content type arguments and pathauto - very important IMO. De-emphasising the descriptions on that page is probably a good thing.

dmitrig01’s picture

Status: Needs work » Needs review
FileSize
3.15 KB

Re-rolled

ultimateboy’s picture

Status: Needs review » Needs work
FileSize
23 KB
81.44 KB

Although the add content type form correctly displays the new "Machine Name" (see Picture 5), the content types list is still not functional (see Picture 4).

dmitrig01’s picture

Status: Needs work » Needs review

Rebuild the theme registry

dmitrig01’s picture

Oops code style errors

Dries’s picture

The code looks good. I think this is RTBC if all tests pass. The testbed results in #19 seem to be out of whack. I'm running on battery so I can't really run all the unit tests right now. Good job, dmitri.

catch’s picture

Status: Needs review » Reviewed & tested by the community

HEAD had testbed failures for a couple of days which I think was the cause of the testbed failures. Ran all tests with this and reviewed the patch + visually, all looks good, so marking RTBC.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.