The documentation page for ModuleUninstallValidatorInterface::validate() shows an implementation example, with the effect that documentation pages for methods overriding ModuleUninstallValidatorInterface::validate() show the implementation example, and the code for the specific implementation, which is itself an implementation example.

The implementation example should be removed, as it is not necessary to have an implementation example in those pages. Even the page for ModuleUninstallValidatorInterface::validate() should not show an implementation example; if I want to see an implementation example, I just go to one of the documentation pages listed under 12 methods override ModuleUninstallValidatorInterface::validate().

CommentFileSizeAuthor
#5 drupal-remove-implementation-example-3020905-5.patch1.14 KBapaderno
#3 drupal-remove-implementation-example-3020905-3.patch103.6 KBapaderno
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kiamlaluno created an issue. See original summary.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Active » Needs review
Issue tags: +Novice
FileSize
drupal-remove-implementation-example-3020905-3.patch103.6 KB
johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev commented
Status: Needs review » Needs work

Patch looks like it has been generated incorrectly, it reverts some commits recently done in core.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Status: Needs work » Needs review
FileSize
drupal-remove-implementation-example-3020905-5.patch1.14 KB

Yes, it has been generated incorrectly: I ran git rebase origin on the wrong branch.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

tvb’s picture

tvb CreditAttribution: tvb commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly to 8.9.x-dev.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

  • xjm committed 7a45330 on 9.1.x 
    Issue #3020905 by kiamlaluno, johnwebdev: Remove the implementation...

  • xjm committed d99c2f8 on 9.0.x 
    Issue #3020905 by kiamlaluno, johnwebdev: Remove the implementation...

  • xjm committed f36ba4b on 8.9.x 
    Issue #3020905 by kiamlaluno, johnwebdev: Remove the implementation...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 9.1.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Fixed

OK, I had to read the IS about four times to understand, but I guess this is fine to fix. 😂

@tvb, the automated testing infrastructure tells us whether the patch applies, so we do not need people to review that. 🙂

Committed to 9.1.x and cherry-picked to 9.0.x, 8.9.x, and 8.8.x. Thanks!

  • xjm committed 580e0ef on 8.8.x 
    Issue #3020905 by kiamlaluno, johnwebdev: Remove the implementation...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.