Layout Builder's isOverridable()/setOverridable() do not respect the result of isLayoutBuilderEnabled()

I have created a patch that implements Proposed Solution - #2 which does the following:

• When setOverridable is called with TRUE and Layout Builder is not already enabled, enableLayoutBuilder() is called

Noting here: the second piece of Proposed Solution - #2 was previously completed.


I have added a test as well

The issue summary says...

Rewrite setOverridable() so that when it is called with TRUE enableLayoutBuilder() is called, and rewrite disableLayoutBuilder() so that when it is called setOverridable(FALSE) is called

Is the second half of that incorrect?

If so feel free to update the issue summary and set back to "reviewed and tested by the community"

Committed and pushed 7ca5921520 to 8.8.x and d950a4dbda to 8.7.x. Thanks!

As a bugfix backported to 8.7.x - thanks for making layout builder have less bugs before its stable release.

FILE: ..._builder/tests/src/Kernel/LayoutBuilderEntityViewDisplayTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
    |       |     1
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

diff --git a/core/modules/layout_builder/tests/src/Kernel/LayoutBuilderEntityViewDisplayTest.php b/core/modules/layout_builder/tests/src/Kernel/LayoutBuilderEntityViewDisplayTest.php
index 04d718b9c1..9a12b74b36 100644
--- a/core/modules/layout_builder/tests/src/Kernel/LayoutBuilderEntityViewDisplayTest.php
+++ b/core/modules/layout_builder/tests/src/Kernel/LayoutBuilderEntityViewDisplayTest.php
@@ -61,7 +61,7 @@ public function testGetRuntimeSections() {
     $this->assertEquals($this->sectionStorage->getSections(), $result);
   }
 
- /**
+  /**
    * Tests that setting overridable enables Layout Builder only when set to TRUE.
    */
   public function testSetOverridable() {

Fix coding standards on commit.