Problem/Motivation

Enabling deprecation notices will identify anything we need to adjust prior to D9 and make sure we stay compatable.

Proposed resolution

Add drupalci.yml file to enable deprecation notice, and fix any issues.

Remaining tasks

User interface changes

none

API changes

none

Data model changes

none

Release notes snippet

CommentFileSizeAuthor
#17 3019796-17.patch7.86 KBheddn
#14 3019796-14.patch7.85 KBheddn
#13 3019796-13.patch7.78 KBheddn
#11 3019796-10.patch1.16 KBheddn
#11 interdiff.txt432 bytesheddn
#7 interdiff.3019796.5-7.txt325 bytesmikelutz
#7 3019796-7.migrate_plus.Run-DO-tests-with-deprecation-notices-enabled.patch1.17 KBmikelutz
#5 interdiff_4-5.txt1.8 KBheddn
#5 3019796-5.patch1.16 KBheddn
#4 interdiff.3019796.2-4.txt300 bytesmikelutz
#4 3019796-4.migrate_plus.Run-DO-tests-with-deprecation-notices-enabled.patch1.17 KBmikelutz
#2 3019796-2.migrate_plus.Run-DO-tests-with-deprecation-notices-enabled.patch1.2 KBmikelutz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikelutz created an issue. See original summary.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer commented
Status: Active » Needs review
FileSize
3019796-2.migrate_plus.Run-DO-tests-with-deprecation-notices-enabled.patch1.2 KB

Just wanted to see what this looks like.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented

Very good idea.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer commented
FileSize
3019796-4.migrate_plus.Run-DO-tests-with-deprecation-notices-enabled.patch1.17 KB
interdiff.3019796.2-4.txt300 bytes

Cool. :-) fixed the lack of newline, but we should add this to ALL the modules. :-)

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
FileSize
3019796-5.patch1.16 KB
interdiff_4-5.txt1.8 KB

I've merged in some changes I've seen elsewhere. Let's see if this also works.

Status: Needs review » Needs work

The last submitted patch, 5: 3019796-5.patch, failed testing. View results

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer commented
FileSize
3019796-7.migrate_plus.Run-DO-tests-with-deprecation-notices-enabled.patch1.17 KB
interdiff.3019796.5-7.txt325 bytes
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: 3019796-7.migrate_plus.Run-DO-tests-with-deprecation-notices-enabled.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented

That's confusing. We're doing very similar to https://cgit.drupalcode.org/jsonapi/tree/drupalci.yml

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs work » Needs review
FileSize
interdiff.txt432 bytes
3019796-10.patch1.16 KB

Status: Needs review » Needs work

The last submitted patch, 11: 3019796-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs work » Needs review
FileSize
3019796-13.patch7.78 KB
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
FileSize
3019796-14.patch7.85 KB

The last submitted patch, 13: 3019796-13.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 14: 3019796-14.patch, failed testing. View results

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs work » Needs review
FileSize
3019796-17.patch7.86 KB

  • heddn committed 9c63eae on 8.x-4.x 
    Issue #3019796 by heddn, mikelutz: Run D.O. tests with deprecation...
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs review » Fixed

Yeah, it passes.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

Seems like the JS tests are failing. Possibly because we have no js nor js tests. Let's fix that.

  • heddn committed 3e25c70 on 8.x-4.x 
    Issue #3019796 by heddn, mikelutz: Run D.O. tests with deprecation...

  • heddn committed da05acc on 8.x-4.x 
    Issue #3019796 by heddn, mikelutz: Run D.O. tests with deprecation...
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

More errors are surfacing. https://www.drupal.org/pift-ci-job/1151068

  • heddn committed 2487ebb on 8.x-4.x 
    Issue #3019796 by heddn, mikelutz: Run D.O. tests with deprecation...
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

Hopefully the fixes for https://www.drupal.org/pift-ci-job/1151089

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

Going to leave this as fixed. But this was a good exercise. We found #3021538: $migration->get('migration_group') causes deprecation warnings.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Issue tags: -Run d.o. testsuite with deprecation notices turned on +Drupal 9 compatibility

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.