Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
\Drupal\Core\Menu\DefaultMenuLinkTreeManipulators::collectNodeLinks() incorrectly documents its return value in the docblock. Actually, this method returns nothing.
Drupal 8.6 and 8.5 have the same issue.
Comment | File | Size | Author |
---|---|---|---|
#8 | 3018912-after_patch.png | 53.47 KB | Abhijith S |
#2 | 3018912-2.patch | 748 bytes | maximpodorov |
Comments
Comment #2
maximpodorov CreditAttribution: maximpodorov commentedComment #3
maximpodorov CreditAttribution: maximpodorov commentedComment #8
Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commentedApplied patch #2 on 9.2.x and it works fine.The documentation about return is removed in this patch.
Comment #9
daffie CreditAttribution: daffie commentedThe method return nothing and the patch removes the docblock part with the return values.
For me it is RTBC.
Comment #10
alexpottCommitted and pushed 36409a3156 to 9.2.x and 19916d48c7 to 9.1.x. Thanks!
Backported the issue to 9.1.x since it is a docs bugs fix.
Hi @Abhijith S thank you for looking into this issue.
Posting screenshots of your codebase or CLI does not advance the issue, since the automated testing infrastructure tells us whether the patch applies correctly.
So, I've removed the issue credit for that screenshot. In the future, you can get credit for issues by reading the issue to understand its purpose, and posting your review or testing of that purpose. Thank you!